[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/7] xen/arm: Wrap shared memory mapping code in one function
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 16 May 2024 13:24:24 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fXXbJmbvR5oz9UhDa4nLJI+eTKj1bhiYZ1E+64sKjEA=; b=QclJ76Kx0v1hQs8i170OMcQSFcL8q19vLJKmt/O1HCa+pr9LmzFS7qdiaU2F0oIxuUJM2IUQkWbJfp+Cslj4zlEuZ3bwaXq37h+LfvSlOsBu0GzFh7550v8R4D+3i5nnZjtibjaW100XIT+IyiWOf3vWAifP/+oFegVGCWaAMRNXpN5BJGmviOqgcV15V7GB7nUmDR8i9JLyOKiOrn7MdGodSsfVmkiPKnPx3wwmvD0//vEpMrRGyIP4JBnmo0FqMcRVpdPkhyxMgTRiVqg1N+HI0vNQn5y3cL4i9m3hDqWp+TE9mjoA6AUwEbqRjcbechGvoNE2ZGQNLgc65y4P8w==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fXXbJmbvR5oz9UhDa4nLJI+eTKj1bhiYZ1E+64sKjEA=; b=fOmFww3OiM75NZnK2gmEqzj1b/foNGrVPbO59QMRPYPXNBU+K+0yg+xUY2i5NEaO+GVhO9jbcDxEevixkj+TYO3hA2mesLLozFTS89OGtUmlO2MUB447qWEtIT9fmKbi6seI9ayjsDTkK5SBOQGjGU+oi/jNopp1Moe71bsYGEPmc+tThi0rifmn9YItA9maI95BuR5m94E6zsobS2s3/bRBraZ0bNKzpTw1A0bVx1JHEY2J06UXxn3lxZ/56OcgoE+8NsauGK1jb5KHyHNzxABtPVljENwGJN2QJV/OVWc+KSVeS22uG9rnFuFzTkamzv7qZkJrNo/UeppYlZP4sg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bFA+GNPf8YhM63yJe4ZFBGYNNUsNOgxidhOdxgpOyT9J7et28uAiLHR/3FB4TWprz7spw4ey5yeDqcbLQCHPDuoNzIQiKypzILDI5HJzkaZ7KvC/dc57kIyZr/qjOr+BME8Wr1RVNttqDui741nzJuMehAnXeDaLuR5pUUhB5iSugQ/EpxLZy3WOOvo1R2PvC2oLyzqKmxnszEpdG5gYb6DIg5xLu39AMy1Z/H6bd7VByHeUw0RmzF1UVjWE2yWSYf/jJZ8nnwM8qUq9FmPmJ2NnkxODe7sunkVY+tb7nbMMqedws14cQErFeiSZtiokV1HcQeE0za4/HOdog0CXCg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tl/movNA4USbwPBnTMXmn1PsVLF2MIrtmgrbLQYzztsLvwru9cTe/fVqCLPKPIf++0XoEm7MFiAZ+FNB4/5jErqjjGRufs+ILCZxESTtrA4g7JYymSyHiueufLbWPhwAVXQk6l+NKtFZ0Zf1/d+FC6uZ6Cz+YsVx6Os1OuAW9PNF0wWJ2v85P0synMDiQ/Wr1BX6v4Kcibvpod8tgPyjyVd+FrW7o1Gub6kvxP11C7GixmPxnE8k6Ai6ivSkY0ydcjhcj33GODTPHI0iDf0nUB9pH1GOsxdo1FRj/tpbyn850XFRZGwGraZx7I7fjvkmoaD2REHN4Ju2bo5mHXWakA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 16 May 2024 13:24:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaptP615847oF42UGhJ4Bg9mW8m7GZ2dcAgAABMIA=
- Thread-topic: [PATCH v2 2/7] xen/arm: Wrap shared memory mapping code in one function
Hi Michal,
>>
>> - /*
>> - * "role" property is optional and if it is defined explicitly,
>> - * then the owner domain is not the default "dom_io" domain.
>> - */
>> - if ( dt_property_read_string(shm_node, "role", &role_str) == 0 )
>> - owner_dom_io = false;
>> + /* "role" property is optional */
>> + dt_property_read_string(shm_node, "role", &role_str);
> This now violates a MISRA rule saying that if a function returns a value,
> this value needs to be checked.
> I think you should check if return value is non zero and if such, assign
> role_str NULL (thus removing such
> assignment from a definition).
Sure, I’ll do it.
>
> Other than that:
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> ~Michal
Cheers,
Luca
|
