[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hotplug: Restore block-tap phy compatibility


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Thu, 16 May 2024 09:52:38 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dUj5FOqbKH7wwT1u1EJdGkPcJ91VQKVB3nhPZyk750A=; b=jfRU/A5eTVg+yAxNntV+2VcNGBJFxJ2GLRmm97B9Sfmvd7D8yOFaCC8F3ZzftmKf7H5k6joL1FuCTtYm8oT6kaiNPDCmYVAHupgEe+U44F8+3weuBmou9xMmQwdp0mJY5HLzadhN7nsWLrRoYVuuhYWoE21Z0wXIP0YfTP6kY/rPIl2dswMRLAE70XMphoZnpdSIBeWc1F5z91/Vy7cdwniUia2aubkJmsqj3SASSYGL3ZH3R4usRtyQ97Li0E/c1+NCP/YeV45pnxhoyvkzSgbK6n85ttRsfVZaFOK0YH4UxrfvyLzxdhUBjmugJP5hnZpkUPrNguR0juiwb5uoMQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FvDcpkHR/OqiTxtQHbcvsg5iNPgiyBsegq95yESeCfpoV8ZZJ05xJJVWj6LZnn/X4YWQzT+BZgMDxCeQHiSedD+wBPWLmiSEGGuZZEDLDw660cA5LAkBntT0+jek3luv4jOOZnYtFsrelufIa0TiADTbkd+bhl7nZIN7a5R+1heR4hXDz34vCCv6GsaYniHXQFNu2Rxh/bvF/OuBs9b4jwaiWtX2SnbsdT/M50wLkjVe4WqhxUElLLzOyJ2BgMkt1LXjdEaZP/VyUTTp5Dv67V9u2zQeWCFoysHi6Q9HkFdktneU2ASxt3JmJYzxlX8Zks06I5aKiSWR2jcKK8TpUg==
  • Cc: Anthony PERARD <anthony@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 16 May 2024 13:52:50 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2024-05-16 03:41, Jan Beulich wrote:
On 16.05.2024 04:22, Jason Andryuk wrote:
From: Jason Andryuk <jason.andryuk@xxxxxxx>

From: Jason Andryuk <jason.andryuk@xxxxxxx>

Two identical From: (also in another patch of yours, while in yet another one
you have two _different_ ones, when only one will survive into the eventual
commit anyway)?

Sorry about that. Since I was sending from my gmail account, I thought I needed explicit From: lines to ensure the authorship was listed w/ amd.com. I generated the patches with `git format-patch --from`, to get the explicit From: lines, and then sent with `git send-email`. The send-email step then inserted the additional lines. I guess it added From amd.com since I had changed to that address in .gitconfig.

backendtype=phy using the blktap kernel module needs to use write_dev,
but tapback can't support that.  tapback should perform better, but make
the script compatible with the old kernel module again.

Signed-off-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Should there be a Fixes: tag here?

That makes sense.

Fixes: 76a484193d ("hotplug: Update block-tap")

Thanks,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.