[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v8 3/5] x86/pvh: Add PHYSDEVOP_setup_gsi for PVH dom0
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Fri, 17 May 2024 09:00:08 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+R+nUC/jdNwPhayFfRejkS/Aq6B3U6J0pxAzdnK0lYQ=; b=YcCtZLenA3k0fWpn/x2g5F5k1Qc1T+U9910t6QeSF2yCkdziuWAHAqm/lcvCuZVBIbguauO5u3vUVH7ptkA2Bb9GMOr1tZWAxnGi03Lgg8WitpYZtugi8MJF4N30xA6RGRfUzHAZfwjxs8SX8oqz4Xv8rfmDPOg4CtakezEz//6foQ/wJm7dgk6PgoopmvUMD7JJXZz/YYlc9ZI1joBWamNUG+JY+YwVXWTZ8j1nx5jF2rs25P/4VVbSjI8rTwt5UAioQ9lTSqjbPZEPjp8KZbMrUTkMBaCJ+3bwp3tQT+0XwWxW5LE7taHpdOU0q9w5rG/EoA/h4WnQX02ctBI5qg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gDT+hcHSiR0vmUhY6mkb5f/+KHLPoAglh1mYnt3uKw9q2v7NeQI53lHzCL9Kl+7FessOhwUvrX0xtGHg2i2QF9jgvADiXFJSQdbxqcWpiDVnUmAfyiLM19jRqffEyZW7D8DtVIl1zAWoxUxzmsgpOQrgVMsvTQOSxpC11u2otoZArWyYsovSbKVh1wgWkxkbGStGavivpdJGB4o1BCy1JZhxjD4UHEh3K4FonhdzCcQKqx57VfaeoQn45RoKx+f+PCgCGGmH27v9fwP4dgDjsHZ3thdCVJQsLtsG40joJgwS3JbNjJc3x5sM0SXnv3B/96YMxEbxOONpcJpPvP9Y/g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony@xxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Fri, 17 May 2024 09:00:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHap3bbllnzPAJ6rEGPUd9rNZSctrGZ4LUAgAHFMQA=
- Thread-topic: [XEN PATCH v8 3/5] x86/pvh: Add PHYSDEVOP_setup_gsi for PVH dom0
On 2024/5/16 21:49, Jan Beulich wrote:
> On 16.05.2024 11:52, Jiqian Chen wrote:
>> --- a/xen/arch/x86/hvm/hypercall.c
>> +++ b/xen/arch/x86/hvm/hypercall.c
>> @@ -76,6 +76,11 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void)
>> arg)
>> case PHYSDEVOP_unmap_pirq:
>> break;
>>
>> + case PHYSDEVOP_setup_gsi:
>> + if ( !is_hardware_domain(currd) )
>> + return -EOPNOTSUPP;
>> + break;
>> +
>> case PHYSDEVOP_eoi:
>> case PHYSDEVOP_irq_status_query:
>> case PHYSDEVOP_get_free_pirq:
>
> Below here we have a hardware-domain-only block already. Any reason not
> to add to there? Yes, that uses -ENOSYS. Imo that wants changing anyway,
> but even without that to me it would seem more consistent overall to have
> the new case simply added there.
Ah yes, I remembered you suggest me to use EOPNOTSUPP in v4, if change to
ENOSYS is also fine, I will move to below in next version.
>
> Just to double check: Is there a respective Linux patch already (if so,
> cross-linking the patches may be helpful)?
Yes, my corresponding kernel patch:
https://lore.kernel.org/lkml/20240515065011.13797-1-Jiqian.Chen@xxxxxxx/T/#mc56b111562d7c67886da905e306f12b3ef8076b4
Do you mean I need to add this link into the commit message once the kernel
patch is accepted?
> Or does PVH Linux invoke the sub-op already anyway, just that so far it
> fails?
>
> Jan
--
Best regards,
Jiqian Chen.
|
