Re: [RFC PATCH v1] xen: arm: Set state to SYS_STATE_smp_boot before smp initialization

[Julien Grall <julien@xxxxxxx>]

Hi Ayan,

Sorry this patch fell through the cracks.

On 20/03/2024 18:54, Ayan Kumar Halder wrote:
> This is similar to what is being done on x86.

OOI, how did you find this issue?

> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>

> ---
>   xen/arch/arm/setup.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 424744ad5e..3d110685bc 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -787,6 +787,8 @@ void asmlinkage __init start_xen(unsigned long 
> boot_phys_offset+
>   
>       processor_id();
>   
> +    system_state = SYS_STATE_smp_boot;
> +
This is not quite the samem position as x86. The system state will be 
updated just before do_presmp_initcalls().
Can you explain the difference?

Cheers,

--
Julien Grall