[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/7] xen/arm: Parse xen,shared-mem when host phys address is not provided
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 22 May 2024 14:07:32 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OddZpErMz4b2RPmJ4CFrNZ+f5/3Au+Xg5aIfEAhcO6w=; b=dFobLSfwMxpi07eUIrbsbFG2WZamZhkBZGQpBwYBkKgybvejMriLFk1m6nRk64xj8QubKV9jaLA+nCOoZGwZZZxIZf+evsuQYaaOQk/VLVeprCnzig/+SOmtfkB/DZQG1jL+p3DrHiXLToTj06aWO12V8wbJgsghX3bo6x9QZl3NXI+duDy/wSwjbW4N9iCjEQnF6o2ZmW726RA8x3X4HitCdep4INkl1VP40jfGiLWt4vzfuwK3tl9JnN2ASkSPnu8mJHQKBqpvQOv79uy5N4JQ/UYJb2mJ7PHfXVJ6ZS5w8hMvE125I5MVXW9wGp+Vft280/KAvCiX6pSpesY7LA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OddZpErMz4b2RPmJ4CFrNZ+f5/3Au+Xg5aIfEAhcO6w=; b=ZN+QAjCzpmdMmguO3/hkdTjycUYi1UgWQ+IHYzlbka/hxYUXYQRuXLismYgcUDTInxOskTP7FVfcUk0yxtR/nqWh9hIJBFmHNuSyTNDXnnSM/Q4QhZohE3NUm+FZnQapNLtHmOY1fQgKJqRFnYZMXKxuZYWG7dFXZNXQNJCBOOsR9dZRMri870cB3uItKqzPlMC256S+QPQtk4ElnqekojuFi1texovnJ2soTA7nlZqzI6+RTNUgw88jlPnxcPnf9CWS8PLphbcRjmGn3qEoEIgt1WW8dzopVUuefzoqHi+5fTH9M6H+yj0gIOFwVndjD3rbdx8oKAG56Xo8N9d2Xw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=MTai4aRKHb6mTEqi18wNfICwSXX/NAR96XS7xxbSpWDzyyizwrJlBrNAOgUtD+DZ3/FjIxmQKpJGBJSyIbqWuuhoH/mJV+bd3RL1z+stafoVWoBiblZ8JCEyaqe6OgjJlRLxu/IXlOXjeAfJU9YzVQRHaeMwokCGSKGqfuFHkMfcKN7XS/J210qcqoEucj/7U6qrfTJ3GiNpkdD2O5b1FOWM32+OzKVHE+CGKyvosRg+xD6JnFMCMLkQQxGFlW2wzlO5ndeNTopkV5GiuiOSW1wt+ekXgPrUBf61dUkL5FZyNYWuMy7W1cjJB6fqOw7T4Os7yCDPZm4UjGqpgOI9fw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AAtvNWadDqjC1cBN/2E8UXm4pm33p+6CPhzxPDRChvyWDIgIyjLHsQR0W4O+TNN/9M2R2IfD/d2vE3DooAEE2mP+YIKUYZTpFJ5krQyBud/YpSTirefXn4cMUB59dg1+GmkW0C60tgnDAoSrni9vokhoRcBLxMJLAnigEQ7Wic2yxJCNCiswaV+DpjkCJslCG3Setv+7uogUZlDwiOI6chErDtBEJliV55TQSxgXh7IthimRD7elfFa/O5rtRw1vjjXXkOGB7tzdf8kgXNluFUQYNf6j72aIdddrbfOec17MWyW3XGe2eNVFa/Zm73eDw0nZD5CCRFESImimkqP8ig==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 22 May 2024 14:07:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHarB0DEGh17L7PW0qcXAGhEqHugbGjRaeAgAAE2QA=
- Thread-topic: [PATCH v3 4/7] xen/arm: Parse xen,shared-mem when host phys address is not provided
Hi Michal,
>> for ( i = 0; i < mem->nr_banks; i++ )
>> {
>> /*
>> * Meet the following check:
>> - * 1) The shm ID matches and the region exactly match
>> - * 2) The shm ID doesn't match and the region doesn't overlap
>> - * with an existing one
>> + * - when host address is provided:
>> + * 1) The shm ID matches and the region exactly match
>> + * 2) The shm ID doesn't match and the region doesn't overlap
>> + * with an existing one
>> + * - when host address is not provided:
>> + * 1) The shm ID matches and the region size exactly match
>> */
>> - if ( paddr == mem->bank[i].start && size == mem->bank[i].size )
>> + bool paddr_assigned = (INVALID_PADDR == paddr);
> Shouldn't it be INVALID_PADDR != paddr to indicate that paddr was assigned?
> Otherwise, looking at the
> code belowe you would allow a configuration where the shm_id matches but the
> phys addresses don't.
You are right, good catch, somehow it escaped testing, I’ll fix in the next push
>
> ~Michal
|
