[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/12] sd: add a sd_disable_discard helper

To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
From: Damien Le Moal <dlemoal@xxxxxxxxxx>
Date: Wed, 29 May 2024 17:10:47 +0900
Cc: Richard Weinberger <richard@xxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Dongsheng Yang <dongsheng.yang@xxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx
Delivery-date: Wed, 29 May 2024 08:11:01 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 5/29/24 14:04, Christoph Hellwig wrote:
> Add helper to disable discard when it is not supported and use it
> instead of sd_config_discard in the I/O completion handler.  This avoids
> touching more fields than required in the I/O completion handler and
> prepares for converting sd to use the atomic queue limits API.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>

-- 
Damien Le Moal
Western Digital Research

References:
- convert the SCSI ULDs to the atomic queue limits API
  - From: Christoph Hellwig
- [PATCH 04/12] sd: add a sd_disable_discard helper
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 03/12] sd: simplify the ZBC case in provisioning_mode_store
Next by Date: Re: [PATCH 05/12] sd: add a sd_disable_write_same helper
Previous by thread: [PATCH 04/12] sd: add a sd_disable_discard helper
Next by thread: Re: [PATCH 04/12] sd: add a sd_disable_discard helper
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.