[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/xenbus: handle potential dangling pointer issue in xen_pcibk_xenbus_probe
- To: yskelg@xxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
- From: Jürgen Groß <jgross@xxxxxxxx>
- Date: Wed, 29 May 2024 14:27:54 +0200
- Cc: skhan@xxxxxxxxxxxxxxxxxxx, sj@xxxxxxxxxx, Austin Kim <austindh.kim@xxxxxxxxx>, shjy180909@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel-mentees@xxxxxxxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 29 May 2024 12:28:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.05.24 14:22, yskelg@xxxxxxxxx wrote:
From: Yunseong Kim <yskelg@xxxxxxxxx>
If 'xen_pcibk_init_devices()' fails. This ensures that 'pdev->xdev' does
not point to 'xdev' when 'pdev' is freed.
Signed-off-by: Yunseong Kim <yskelg@xxxxxxxxx>
---
drivers/xen/xen-pciback/xenbus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
index b11e401f1b1e..348d6803b8c0 100644
--- a/drivers/xen/xen-pciback/xenbus.c
+++ b/drivers/xen/xen-pciback/xenbus.c
@@ -54,6 +54,7 @@ static struct xen_pcibk_device *alloc_pdev(struct
xenbus_device *xdev)
INIT_WORK(&pdev->op_work, xen_pcibk_do_op);
if (xen_pcibk_init_devices(pdev)) {
+ pdev->xdev = NULL;
kfree(pdev);
pdev = NULL;
}
NAK.
This doesn't make any sense, as pdev is freed.
Juergen
|
