Re: [PATCH 2/3] CI: Use a debug build of Xen for the Xilinx HW tests

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 29/05/2024 4:30 pm, Michal Orzel wrote:
> Hi Andrew,
>
> On 29/05/2024 16:19, Andrew Cooper wrote:
>>
>> ... like the other hardware tests.  This gets more value out of the testing.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> CC: Michal Orzel <michal.orzel@xxxxxxx>
>> CC: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>> CC: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
>> ---
>>  automation/gitlab-ci/test.yaml | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml
>> index efd3ad46f08e..e96ccdfad54c 100644
>> --- a/automation/gitlab-ci/test.yaml
>> +++ b/automation/gitlab-ci/test.yaml
>> @@ -149,7 +149,7 @@ xilinx-smoke-dom0less-arm64-gcc:
>>      - ./automation/scripts/xilinx-smoke-dom0less-arm64.sh 2>&1 | tee 
>> ${LOGFILE}
>>    needs:
>>      - *arm64-test-needs
>> -    - alpine-3.18-gcc-arm64
>> +    - alpine-3.18-gcc-debug-arm64
> This change should be reflected in the name of the test changed (here and 
> below), so that it contains -debug suffix just like every other debug job.
> With that done:
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

Wow, this is a giant mess.  There's no consistency anywhere.

I've got a debug suffix for this one, and a debug infix for the other
one, but I'm seriously tempted to sed over the whole config and clean
this up for once and for all.

~Andrew