Re: [XEN PATCH v2 04/13] x86/vpmu: address violations of MISRA C Rule 16.3

[Federico Serafini <federico.serafini@xxxxxxxxxxx>]

On 24/06/24 17:16, Jan Beulich wrote:
> On 24.06.2024 11:04, Federico Serafini wrote:
> > --- a/xen/arch/x86/cpu/vpmu_intel.c
> > +++ b/xen/arch/x86/cpu/vpmu_intel.c
> > @@ -713,6 +713,7 @@ static int cf_check core2_vpmu_do_rdmsr(unsigned int msr, 
> > uint64_t *msr_content)
> >               break;
> >           default:
> >               rdmsrl(msr, *msr_content);
> > +            break;
> >           }
> >       }
> >       else if ( msr == MSR_IA32_MISC_ENABLE )
> Up from here, in core2_vpmu_do_wrmsr() there's a pretty long default
> block with no terminating break. Is there a reason that you don't put
> one there?
I noticed that vpmu_intel.c is a file out-of-scope.
The violation I addressed was shown because it involves
the macro rdmsrl coming from file xen/arch/x86/include/asm/msr.h
(in scope).
I will address also the violation you pointed out in a v3.

--
Federico Serafini, M.Sc.

Software Engineer, BUGSENG (http://bugseng.com)