[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.20] xen/arm: dom0less: Add #redistributor-regions property to GICv3 node


  • To: Michal Orzel <michal.orzel@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Thu, 4 Jul 2024 08:39:44 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t7wv1gyWKHNKDF+fHFoQBtFgIc3ke44LpXbpRzajLlQ=; b=SHPhcM+7kh8BlISdPFCslqQG2CEPrVu9hn2PEN28YhRNP3iTtzYqnVLJfN3ZYRhGQlBgnMcLM6qj4R3VhsQqIh9YrnkcL8k2K2M/VoQI+7qDNcv49Ql1gdK6YRa2A7MEI5gcou099cB8iLlxx5ki1E4++V4FiVX0sKnDZXK8e7/3L9rRT/3ZnkItx2J+c/Dm+EWBxq+ySQwXOCYKQKLpbPqAOaDNFlNOP2uYUGpkP98xMpp8wf31pDHQ9y7xkayN87mWrknr0UsWw7YHi2tUFLIlfnRVPqbBbU5RvPscvDczoMqCT1jgX8Iokm90yQ/pPdEhZUUE1zT1kUt+3GM3ug==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t7wv1gyWKHNKDF+fHFoQBtFgIc3ke44LpXbpRzajLlQ=; b=jh2/1SrbJgddVWN8tDkgYG57vw8zzrsHOPEvTBJHwGfZCU25LY1Avs2lQNXT7m01cqPyus0WJOsfz5xbrmk8AluJeIN7jQ0X43zkxvVXVWdkd0StBrleeK/UQh99mjUGDofeDumjXwW0TyPvW/cTy5sKP4//o0YhUf+ILUVfrvJ5MXjJUQ6jm85so9h37VQTXVmy4YkDOc1nw4kYy2+MTxUw39U3++CxRSPcD4TRTMPhGFtDqk6sovhOUH7TzovH73xVHzPE/kUlNHcDyBxXcXeKqeN2wqRC6gqAoov5t+3NBmivpSsV2ysODo4CR3Zcw7aCWF77sZNnrRossat9Kg==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AT5T1blVBQcJ1wkXKZeuORYX+IfGITmSe4ecOYISwiIZ3YdkW2R2/B7ZFSONt0FtvwdmGHk3dgJo1/94KA1A7RLGKQQm8Ddz7sWnhx2LgQXj5JJi4RTP31JPMpR+YS1Y1b4bldtDqbbu2CDgtq6MTle6jCO84d/qH5tNBu+ZT0pIHGZfx0MJP652HUxKZimq0l9WZHf2V6f7yN3RL1Ep7DNYsOknVqeCSc2Ik9aTLwud1BUfNMHbB3JfhklfmRKgLCIW8GAk+PYmP68slCbkHRbOsly9r7pUZazxz6wSuHScWb5DEXyz/1FK/1uRNAe9khcvOjfUoG6wM2TAeml56Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PQ5Q/Q5HQJn+ikiDYZLgQTKSA0hBZObwRWoWmK3tssyd9X67ADag2OQLv9yxmi81ZrvCSjWRgtkZE2WWT4VeaalkXxwaTVIr7i19RCHy7LDckfmKKphptz4VBtegSUQ39TZU0WRBgmDO+0HLnVMV6+ptCM741sWAihaqM1jDWAF7LQKbqG9nDW669AMVqaZHz7wjKygI+ZUPuDA9acLWutvrNjuoAZrmcAzLdkl/Gi3y96yQhfxRUSbA0E4W8CCqDZ6fK9ooaZluFgINn0+dflhzJ1z8MRzZu9Uiv9m9W07K7hlv/xXJeiA78q2eOigIA5s++QNIu2zKUuB0iQMSfA==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Thu, 04 Jul 2024 08:40:13 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHazed12zZt44Ds3ki/zr1lurRVMbHmP5UA
  • Thread-topic: [PATCH for-4.20] xen/arm: dom0less: Add #redistributor-regions property to GICv3 node


> On 4 Jul 2024, at 08:54, Michal Orzel <michal.orzel@xxxxxxx> wrote:
> 
> Dom0less domain using host memory layout may use more than one
> re-distributor region (d->arch.vgic.nr_regions > 1). In that case Xen
> will add them in a "reg" property of a GICv3 domU node. Guest needs to
> know how many regions to search for, and therefore the GICv3 dt binding
> [1] specifies that "#redistributor-regions" property is required if more
> than one redistributor region is present. However, Xen does not add this
> property which makes guest believe, there is just one such region. This
> can lead to guest boot failure when doing GIC SMP initialization. Fix it
> by adding this property, which matches what we do for hwdom.
> 
> [1] Linux: 
> Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
> 
> Fixes: 4809f9ec7d71 ("xen/arm: if direct-map domain use native addresses for 
> GICv3")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---

Looks good to me!

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>






 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.