Re: [PATCH 1/2] build/mkheader: Remove C-isms from the code

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Wed, Jul 03, 2024 at 11:55:24PM +0100, Andrew Cooper wrote:
> This was clearly written by a C programmer, rather than a python programmer.
> Drop all the useless semi-colons.
> 
> The very final line of the script simply references f.close, rather than
> calling the function.  Switch to using a with: statement, as python does care
> about unclosed files if you enable enough warnings.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 

Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech