[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] automation: fix false success in qemu tests
- To: Michal Orzel <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Lira, Victor M" <VictorM.Lira@xxxxxxx>
- Date: Thu, 29 Aug 2024 10:23:44 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KJJTaqkI3DYB+NOL0fCH1RyECZlhQQPbFR4pvG2MHJ0=; b=HGz6jn4jlkNQaAw2ymvTi0jBk3TDxHD4U+vmXmJroB8oM4p0Wj9VB5Tp04DlvWf6z26bs4ZebHXwDqVoyt7FDbrNKPhsXV7Cxwiy3CfMu7Lu0rg4xIZv7rF2W2yDtfctx9MfzycOptnMLE2ghm2YnX9IVmo25jR/xkOJWjzU+aCasP3I2EPnDvIDPcRavwINNOSHnAR/cASedu8bvkXVt2PIsKJ5dL/zUM/XBhd+11qsdYUEqszZ4v7ByOxQ+bQoBv0ZRhlc7ZYSZJ3wRaxo/arnwOM82uOV8EZzIEfJhBmaw26h0AvOAtpCwXgkyMVb6+YBoWSqqtvDWFDcPJmGsQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VY3itrknVLqDtjMIiTJ+4vOyIsINHvrj+qnbeAW2hfitq6cMLadI0gFJ1A+DEH81eV16Fx/F6dFwwVX3oBWCaZe8LFEm7u4TCuiws4xGFxoJFpGy55a/subQX6lr9djfSUkkk6zD7TbtNjPufrYiwciAjqVCMgSor7UdNHxOAoPh5a2eKD9IKXPG4dAoCfpQ7aoak8xG+CtLDfDRq2p/Ucd6p7YemYrqPq/dp7W33CfSy8djW7NYvBVMW+xcYO8iJX1t9+nm8IJkApg8KfT6ySbWhxy3f6/a7fQX3CT6yYNSNAwgO0dXHWj34hP73yHsYrySDK4Ruj3ZqaUoWoIpDQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 29 Aug 2024 17:24:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hello Michal,
Unfortunately only removing "set +e" did not fix the issue as the test
still will always pass.
See here (line 90):
https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/7700210695
I think we will need to use the fifo or the Bash "pipefail" function.
You may want to use "Fixes" tag. See docs/process/sending-patches.pandoc.
This commit tries to do 2 thins at once:
- fix "set +e" issue
- make xilinx tests use expect
These should be 2 separate patches. The first patch should only remove "set +e"
from qemu patches.
There is no need for fifo in qemu tests. You should use that only in xilinx tests where
we cannot remove "set +e".
~Michal
OK, I will review the doc and create separate patches for fixing the
qemu and xilinx tests.
Victor
|
