Re: [PATCH v1] automation: fix false success in qemu tests

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 28 Aug 2024, Lira, Victor M wrote:
> Hello Michal,
> 
> Unfortunately only removing "set +e" did not fix the issue as the test still
> will always pass.
> See here (line 90):
> https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/7700210695
> 
> I think we will need to use the fifo or the Bash "pipefail" function.

pipefail is better if possible


> > You may want to use "Fixes" tag. See docs/process/sending-patches.pandoc.
> > This commit tries to do 2 thins at once:
> >   - fix "set +e" issue
> >   - make xilinx tests use expect
> > 
> > These should be 2 separate patches. The first patch should only remove "set
> > +e" from qemu patches.
> > There is no need for fifo in qemu tests. You should use that only in xilinx
> > tests where we cannot remove "set +e".
> > 
> > ~Michal
> 
> OK, I will review the doc and create separate patches for fixing the qemu and
> xilinx tests.
> 
> 
> Victor
> 
>