[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] arm/gicv3: Fix ICH_VTR_EL2.ListRegs mask


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Tue, 3 Sep 2024 14:21:47 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aSk0fsVcl6ocAsoynP5Vvt3SXW0D/gtDvLdpwDdVEqU=; b=Wgtaq0Ty1NzRTCnZfJWwusFlDo25xYS2t6PZtOu6jcgfbkyfNIU2Lr7SCYc7dBh73hBFV8a9h9bBavKRDcLAW8VztyXQTJn6FywjZitVoVRK0iraT52dMBZxhAfp+AYaGQ7SvCb112+YvKQi6xrn/gXdsyJMzZ8/u9PaIllqFpoB7ggKzqvArT4Xwvp+77WzKfuq8pPa7z+QD+lux6zJ8P2dwa6sh4b56WoPndU7j7LV69A3hx3vVc7cIAB9a2CflMglREkxFfNkXNpDxPalNQO9gcCW86meRisce/B6ftab6NoYcilgZE4J6coSzkFPSdj5ab0hVyjqm8vMb7a0CA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xv9OPOGXfKxeL7IrGbdz/btbkQIbdCLhtKQV67tKanUF2qyxmAxT2qBNUJODPszcZGq0/Npos4UzAwk9isSLjnhgEK4hC8BIB3gqAGsg3k75CJ5qkB5sQ3nHyf8Md81JlOFDzmx+uU/NVKLWH+Bj3d331+Xt+KfvMFf+y8K6FqUgfClmk7jgVGY7nGn+bI8h9SQOaGT3UKiE3YKvtcimD3zJMGsdjtNXexNEiXU3i0lCcI3JGdlhj0ZkOvblkt8c8ayf0M2h5tZiz/z1rPj1axxDcOYUE1MDbsvIROK7ftKT0nx9Jb3JtBsDjj2GIDmZfSXSuBJYz2ad1Ku36ja0ww==
  • Cc: Michal Orzel <michal.orzel@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Tue, 03 Sep 2024 12:22:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

According to GIC spec IHI 0069H.b (12.4.9), the ListRegs field of
ICH_VTR_EL2 can have value between 0b00000..0b01111, as there can
be maximum 16 LRs (field value + 1). Fix the mask used to extract this
value which wrongly assumes there can be 64 (case for GICv2).

Fixes: bc183a0235e0 ("xen/arm: Add support for GIC v3")
Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
---
 xen/arch/arm/include/asm/gic_v3_defs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/include/asm/gic_v3_defs.h 
b/xen/arch/arm/include/asm/gic_v3_defs.h
index 227533868f8d..2af093e774e5 100644
--- a/xen/arch/arm/include/asm/gic_v3_defs.h
+++ b/xen/arch/arm/include/asm/gic_v3_defs.h
@@ -189,7 +189,7 @@
 #define ICH_LR_GRP1                  (1ULL << 60)
 #define ICH_LR_HW                    (1ULL << 61)
 
-#define ICH_VTR_NRLRGS               0x3f
+#define ICH_VTR_NRLRGS               0xf
 #define ICH_VTR_PRIBITS_MASK         0x7
 #define ICH_VTR_PRIBITS_SHIFT        29
 
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.