[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v7 3/8] xen/riscv: set up fixmap mappings
On 13.09.2024 17:57, Oleksii Kurochko wrote: > Set up fixmap mappings and the L0 page table for fixmap support. > > {set, clear}_fixmap() is expected to be implemented using > map_pages_to_xen(), which, in turn, is only expected to use > arch_pmap_map(). Now you've left out what you actually mean to justify here: The exposure / direct access to xen_fixmap[]. I'd also suggest to drop "only" - I guess I used that in a reply to v6 to emphasize what I wanted to get across, but it makes not as much sense here. Instead adding "during early boot" at the end of the sentence may provide additional context. > Define new macros in riscv/config.h for calculating > the FIXMAP_BASE address, including BOOT_FDT_VIRT_{START, SIZE}, > XEN_VIRT_SIZE, and XEN_VIRT_END. > > Update the check for Xen size in riscv/lds.S to use Nit: xen.lds.S > XEN_VIRT_SIZE instead of a hardcoded constant. > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx> With the adjustments (again doable while committing) Acked-by: Jan Beulich <jbeulich@xxxxxxxx> Jan
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |