Re: [PATCH v2 1/2] xen: introduce common macros for per-CPU sections defintion

[oleksii.kurochko@xxxxxxxxx]

On Tue, 2024-09-24 at 18:01 +0100, Andrew Cooper wrote:
> On 24/09/2024 5:42 pm, Oleksii Kurochko wrote:
> > Introduce PERCPU_BSS macro which manages:
> >  * Alignment of the section start
> >  * Insertion of per-CPU data sections
> >  * Alignment and start/end markers for per-CPU data
> > This change simplifies the linker script maintenance and ensures a
> > unified
> > approach for per-CPU sections across different architectures.
> > 
> > Refactor the linker scripts for Arm, PPC, and x86 architectures by
> > using
> > the common macro PERCPU_BSS defined in xen/xen.lds.h to handle per-
> > CPU
> > data sections.
> > 
> > No functional changes.
> > 
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
> > Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> > ---
> > Changes in V2:
> >  - rename PERCPU_SECTION to PERCPU_BSS
> >  - update the commit message
> >  - add Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
> >  - add Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> > ---
> > 
> >  xen/arch/arm/xen.lds.S    |  9 +--------
> >  xen/arch/ppc/xen.lds.S    |  9 +--------
> >  xen/arch/x86/xen.lds.S    |  9 +--------
> >  xen/include/xen/xen.lds.h | 10 ++++++++++
> >  4 files changed, 13 insertions(+), 24 deletions(-)
> 
> Aren't you missing a hunk in riscv/xen.lds.S ?
I thought it would be better to add a hunk in riscv when
percpu_init_areas() will be called in RISC-V's start_xen().

~ Oleksii