[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 00/44] Boot modules for Hyperlaunch


  • To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Tue, 8 Oct 2024 16:07:18 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=apertussolutions.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yJnNbXUqgnvDHOeVPbx6Ki6reQT/IHVy4rJaQTjB93I=; b=kVEf/y5FBfYLl34vg5pQk/53BwF71kog5rmD4PzxJ4q0Vr8TG8nneVREZynsxl+3IATKzhJXx04vvV689HuMcEdzTcSuZGN0kDrX6xeZxuL/A9Yfgp/SZ9wjWnvZK/D6R1c6W92eDP2J05cWIuW7M61TZ3fxgi6rjYrSwS9S9CgKNGaIL1Iysn9QlYp67bfR8uT2KssJ9ITKmP+1g3YbQmGDvriawTheBOoelwKQKYEo66f3wzMN+E3lzVQqwQWNb8iMgSgR+E7yd2h2SRULOszpCnW3Ae022TFC9Eu65ADC43oYFJK8HOC/XW8mljECygoIw+D1HflCI+Gx0A909w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sZkRU3xAnDiky3Cm/109Dw74ME1astqkDuBvsG8chZ4484kQoQ0HLlaOdUudOXiCcHI65kkSRTw9z0PQIxgcicZcRV2AJJCUELf/uVGra1Dq2DPJS4VDtz4ChybBRRRtVS4FEPOf50JGpdLahaQhkF4iH4s8A9ZZRw5CBbjbSCQnLp51fGrTzrBCWV2WFSGPeOMfqlnRVBssLi2jzYD/NxOEye3n2n7ptnjNvwX/V6Z7QG0yk2njzxnLE+nqvMZy0GlpTQyjPGbqXOfOGQszI1var69kacKrDqTFH5qMZYyPg4zt+qQSZw1ai2RjMWLJPqClyTLlKu23L/0bZGQfqA==
  • Cc: <christopher.w.clark@xxxxxxxxx>, <stefano.stabellini@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 08 Oct 2024 21:08:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2024-10-06 17:49, Daniel P. Smith wrote:
The Boot Modules for Hyperlaunch series is an effort to split out preliminary
changes necessary for the introduction of the Hyperlaunch domain builder
logic. These preliminary changes revolve around introducing the struct
boot_module and struct boot_domain structures. This includes converting the
dom0 construction path to use these structures. These abstractions lay the
groundwork to transform and extend the dom0 construction logic into a limited,
but general domain builder.

The splitting of Hyperlaunch into a set of series are twofold, to reduce the
effort in reviewing a much larger series, and to reduce the effort in handling
the knock-on effects to the construction logic from requested review changes.

Much thanks to AMD for supporting this work.

Documentation on Hyperlaunch:
https://wiki.xenproject.org/wiki/Hyperlaunch

Original Hyperlaunch v1 patch series:
https://lists.xenproject.org/archives/html/xen-devel/2022-07/msg00345.html

There is a lot of re-formatting of function arguments like:

-static int __init pvh_load_kernel(struct domain *d, const module_t *image,
-                                  unsigned long image_headroom,
-                                  module_t *initrd, void *image_base,
-                                  const char *cmdline, paddr_t *entry,
-                                  paddr_t *start_info_addr)
+static int __init pvh_load_kernel(
+    struct domain *d, const struct boot_module *image,
+    struct boot_module *initrd, void *image_base,
+    const char *cmdline, paddr_t *entry, paddr_t *start_info_addr)

I feel like the old style is more common and I prefer it. But I also don't see it specified in CODING_STYLE. As I am not a maintainer, I'd like them to weigh in.

Also, it is nicer to include a per-patch change log instead of just a cover-letter one. That will be useful in subsequent review rounds to clearly identified changed patches.

Thanks,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.