[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 40/44] x86/boot: add cmdline to struct boot_domain
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Tue, 8 Oct 2024 16:05:35 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=apertussolutions.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zDoDz8P6bipSX9y4XA4VIlW60nkGGhvmirxn2RWYrc4=; b=M7LJivlvIdmcfZ+wtT2QHszMNU0uZ4S/51EKAEkX7jpTcpGr/UvJrGhTIARIzrHXbnMJGTx+uU0Q0YNWTdM3BliCoWi8dlPGSFaZed0MgcTPX2qeaUdCdDuwQ53OBxKb4YcLwB6cTL8y4SUeLbCIHkOszQIikUdqCO3AuwA8iquR9SqKHrMJ9qLqfQUywZdPDWhLCuCkM6aan6gcbnJjf8hyrI7v4X3cr/XxIyib1r8wMltFFPrsnjz9IFKpoxpTwvSeICQ1YXjW+fExRlKZTdVSNOrLSrJwSk4DFPKQSqaQuqIj3mENaFbDfcpi89vkEsUZR2qImwx8asUI8PtK4g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r6aR+iqX8GmrhWnIsqEtaszg8NxctAY4puSJYsioIxY4C8Pwh7d2N02vazmal5yWFXoSSg5eI6gizu4rPCbbmf763edhohLYXqqx1hICU0xs2B5pQ8jmtSdqsFXmx0Uetj3uMgxvHYWrqBBn3PgdZjqgnG4pNE49RtdJDoVaFEdHhCxz09duiYYWxMXzCMKwfwTbv8kx9dHVv28a75otiFkHc4KuFujifwwkpbVoYpcz0ZwuT4TAzu5JjvxP6tfXbbCtwa6Wih1YOO8DVfvseDZWke0eMwUlnQOeeuR8W8j1ekaTHKuIdigiap0RNhwftUKXI22rZ0ewGiUzdpHDkw==
- Cc: <christopher.w.clark@xxxxxxxxx>, <stefano.stabellini@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 08 Oct 2024 21:06:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2024-10-06 17:49, Daniel P. Smith wrote:
Add a container for the "cooked" command line for a domain.
Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
---
xen/arch/x86/include/asm/bootdomain.h | 4 ++++
xen/arch/x86/setup.c | 18 ++++++++----------
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/xen/arch/x86/include/asm/bootdomain.h
b/xen/arch/x86/include/asm/bootdomain.h
index d6264d554dba..00f7d9267965 100644
--- a/xen/arch/x86/include/asm/bootdomain.h
+++ b/xen/arch/x86/include/asm/bootdomain.h
@@ -8,9 +8,13 @@
#ifndef __XEN_X86_BOOTDOMAIN_H__
#define __XEN_X86_BOOTDOMAIN_H__
+#include <public/xen.h>
+
struct boot_module;
struct boot_domain {
+ char cmdline[MAX_GUEST_CMDLINE];
+
1024 bytes for just dom0 isn't too much. But when hyperlaunch has 64
boot_domains, that's a good bit more. But I suppose it isn't too much
RAM for a modern system. This is __initdata, so it increases the binary
size. I just want to highlight this in case others want to chime in.
The code changes seem fine.
Regards,
Jason
|
