[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 44/44] x86/boot: convert dom0_construct_pvh to struct boot_domain


  • To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Tue, 8 Oct 2024 15:56:36 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=apertussolutions.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5h5S6DOHDJCzzNCyyo0bCfCbK8FjeqxMoSEmOLCDoiE=; b=kCTocmqgjVDNMD5owgZC2c/x8bWp5YSnn7fLafNyBs6A/EZSQwC6LrNUIMxSKteLN/EnW4CCwTlCQRdbB2bTl+mFBWYZUIA5OFYTwiWiUbwpIpJ756F1AB/zcY4BCNKjrN2M/js9dSCn0w4xntX+bjt+lghPZX8rRyu1ExlNC23XGenxtXiE27Tw+oK++QvlWOnlcvez+6aujQddvSNeNDZDAvvsY+lrDqny3yvkj+NUV5TsdjCtHBJ4v1I3kIltvrm4c9BdAxPJ2jZZFyyiGvUmodGfAkEyrFLgW6Ftzwz2ujOSGS6LqqtgoBISMpvBZPh+uV2P7UZuLNQwcCcWgA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QTbbbvji3c6B8RK2b6upbhJ79xkYaYv8Vzyx0J/dOt5YGaPEcUaniAODc6WelDuIliQvv7+jBbD2qOYCAAcJO3hr7gNlebDjaWhT5NI38cKxc+Wi/zo6dA8aRhiV8dtedGRjI+HRNoLw8s5Mf1olbGVY6K4m4h3pTc/3GwJOqXCoHMhVycNRJobSbEz1C1R2JlL7UYrRMYvSbmKzghePLG+ZrwcZQcSzboESE5nufBzfFbuFg7aWf/M/oNqo5Ko9M3Z75iXHMTyup6G/20LcfvF2HrL90Zo/kSM6Bd5vqeQ/Dud5Utiwq5/P0iId7zUEn/7UV8vyaUongLN7K61J5A==
  • Cc: <christopher.w.clark@xxxxxxxxx>, <stefano.stabellini@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 08 Oct 2024 20:57:33 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2024-10-06 17:49, Daniel P. Smith wrote:
With construct_dom0 consuming struct boot_domain, continue passing the
structure down to dom0_construct_pvh.

Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>

diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c
index a3fd5e762dc4..755e257cdf30 100644
--- a/xen/arch/x86/hvm/dom0_build.c
+++ b/xen/arch/x86/hvm/dom0_build.c
@@ -1299,25 +1299,23 @@ static void __hwdom_init pvh_setup_mmcfg(struct domain 
*d)
      }
  }
-int __init dom0_construct_pvh(
-    struct domain *d, const struct boot_module *image,
-    struct boot_module *initrd, const char *cmdline)
+int __init dom0_construct_pvh(const struct boot_domain *bd)
  {
      paddr_t entry, start_info;
      int rc;

Again, I recommend using a local struct domain *d to cut down on the churn.

Regards,
Jason

- printk(XENLOG_INFO "*** Building a PVH Dom%d ***\n", d->domain_id);
+    printk(XENLOG_INFO "*** Building a PVH Dom%d ***\n", bd->domid);
- if ( is_hardware_domain(d) )
+    if ( is_hardware_domain(bd->d) )



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.