Re: [PATCH v5 43/44] x86/boot: convert dom0_construct_pv to struct boot_domain

[Jason Andryuk <jason.andryuk@xxxxxxx>]

On 2024-10-06 17:49, Daniel P. Smith wrote:
> With construct_dom0 consuming struct boot_domain, continue passing the
> structure down to dom0_construct_pv.
>
> Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
> diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c
> index 16b8c1e40998..34974aa7cd56 100644
> --- a/xen/arch/x86/pv/dom0_build.c
> +++ b/xen/arch/x86/pv/dom0_build.c
> @@ -354,10 +354,7 @@ static struct page_info * __init alloc_chunk(struct domain 
> *d,
>       return page;
>   }
>   
> -static int __init dom0_construct(struct domain *d,
> -                                 const struct boot_module *image,
> -                                 struct boot_module *initrd,
> -                                 const char *cmdline)
> +static int __init dom0_construct(struct boot_domain *bd)
>   {
>       int i, rc, order, machine;
>       bool compatible, compat;
> @@ -373,11 +370,12 @@ static int __init dom0_construct(struct domain *d,
>       struct page_info *page = NULL;
>       unsigned int flush_flags = 0;
>       start_info_t *si;
> -    struct vcpu *v = d->vcpu[0];
> -    void *image_base = bootstrap_map_bm(image);
> -    unsigned long image_len = image->size;
> -    void *image_start = image_base + image->headroom;
> -    unsigned long initrd_len = initrd ? initrd->size : 0;
> +    struct domain *d = bd->d;
> +    struct vcpu *v = bd->d->vcpu[0];
This can stay:
    struct vcpu *v = d->vcpu[0];

With that:

Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>