[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 43/44] x86/boot: convert dom0_construct_pv to struct boot_domain
- To: Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 9 Oct 2024 20:49:54 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728521398; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=NNKOfYBwW6ac4MKfufnn4w2/OIYAggKc4UDv6sB8Ytg=; b=BokSoqe+L8PRpvL1EIBw4zgcCZvBpjMqRoD4hN6HfIVvHwVpRzQWTeW3QT7B6b7l8tLOwYnJ8ibRSmkPT2PYyyzjAtvL77AOAIpATDyqfJVTPJZnMjSS6Q27RAHkcFrJRci+7K9SGku3zVJiaxA1SNtxI/5Xl26+U7sc7jHBCS8=
- Arc-seal: i=1; a=rsa-sha256; t=1728521398; cv=none; d=zohomail.com; s=zohoarc; b=BGKNCTKR7Iu8qOl7PZWKH6TTzqTpRMmqDofsp9PNTBxerM3bLXWKlpgYfJSgyQ/Lj/BPfp9+nwL51wV4XM6g2d1o3f11TT2SVPLLUyounAJl8/8bvkC4mxEyVkbXN6gpEZ2ee+rI95KhgRLNDX1IQbanoDuvN2x6XRY+dNhX1SI=
- Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 10 Oct 2024 00:50:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/8/24 15:54, Jason Andryuk wrote:
On 2024-10-06 17:49, Daniel P. Smith wrote:
With construct_dom0 consuming struct boot_domain, continue passing the
structure down to dom0_construct_pv.
Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c
index 16b8c1e40998..34974aa7cd56 100644
--- a/xen/arch/x86/pv/dom0_build.c
+++ b/xen/arch/x86/pv/dom0_build.c
@@ -354,10 +354,7 @@ static struct page_info * __init
alloc_chunk(struct domain *d,
return page;
}
-static int __init dom0_construct(struct domain *d,
- const struct boot_module *image,
- struct boot_module *initrd,
- const char *cmdline)
+static int __init dom0_construct(struct boot_domain *bd)
{
int i, rc, order, machine;
bool compatible, compat;
@@ -373,11 +370,12 @@ static int __init dom0_construct(struct domain *d,
struct page_info *page = NULL;
unsigned int flush_flags = 0;
start_info_t *si;
- struct vcpu *v = d->vcpu[0];
- void *image_base = bootstrap_map_bm(image);
- unsigned long image_len = image->size;
- void *image_start = image_base + image->headroom;
- unsigned long initrd_len = initrd ? initrd->size : 0;
+ struct domain *d = bd->d;
+ struct vcpu *v = bd->d->vcpu[0];
This can stay:
struct vcpu *v = d->vcpu[0];
Ack.
With that:
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Thanks!
v/r,
dps
|
