[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 42/44] x86/boot: convert construct_dom0 to struct boot_domain
- To: Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 9 Oct 2024 20:48:46 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728521330; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=a3VU1X5SA5I7VYI789eu+HfeUv6MaDgsObZz5TaOGpQ=; b=DcQxUhXU4ICvrNKDME13tsAqPY37m58mStP6LOykYLBO0pXrC/oqYU/SPcyVNRKmjx9lqKD8D05fyW9AcMs/MPjAU1WoQt2kIOpIrRHvKOjvWKaSh5ML6BekzSp0rNcf9QItqNFDxVSboh5OyVfXs3qU9gOOgtEgFDUv8Lsy0Dc=
- Arc-seal: i=1; a=rsa-sha256; t=1728521330; cv=none; d=zohomail.com; s=zohoarc; b=RP1K6fjitmnKWpbyLLfm2Mmspb+2/k/+C5shkF3JFXW6iKszLKLXHT/MoUmEGdSW5zzYdfapAJJPQSKtk2xTlyNWGdmOqbLOMJQO3vrKSXAX0nU+4aA2tE4gEEuJCJHocSJw1hJlr6MvFAOfHaWvY0aZJU9hkEYFByrR85n3iWE=
- Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 10 Oct 2024 00:49:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/8/24 15:47, Jason Andryuk wrote:
On 2024-10-06 17:49, Daniel P. Smith wrote:
A struct boot_domain now encapsulates the domain reference, kernel,
ramdisk,
and command line for the domain being constructed. As a result of this
encapsulation, construct_dom0 can now take a single struct boot_domain
instead
of these four parameters.
Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
---
xen/arch/x86/dom0_build.c | 19 +++++++++----------
xen/arch/x86/include/asm/setup.h | 4 +---
xen/arch/x86/setup.c | 2 +-
3 files changed, 11 insertions(+), 14 deletions(-)
diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c
index 71b2e3afc1a1..e552f2e9abef 100644
--- a/xen/arch/x86/dom0_build.c
+++ b/xen/arch/x86/dom0_build.c
@@ -597,22 +597,21 @@ int __init dom0_setup_permissions(struct domain *d)
return rc;
}
-int __init construct_dom0(struct domain *d, const struct boot_module
*image,
- struct boot_module *initrd, const char
*cmdline)
+int __init construct_dom0(struct boot_domain *bd)
{
int rc;
I think a local variable would be better:
struct domain *d = bd->d;
The patch is smaller, and using just d is common in the hypervisor.
Ack.
v/r,
dps
|
