[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 40/44] x86/boot: add cmdline to struct boot_domain
- To: Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 9 Oct 2024 20:45:19 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728521124; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=PeU09RrBphn0uYPHwAaljcCdpkNjVuQhRTQBfmhzAFo=; b=nf1AStuYmAweO4/JznYyPjkkh6B5vbcUeo34nVMpNzk/WsWy51Eooijyn2Cqiwq9dCzCfCkyf0YcWeFLhuhnLTafCPn3cjcd1rZB7g+vGSsGLXF3Bc1v6NzOR5bj2qdf0WtUtcdAUlk2FEaznFY9j235U2baPrrGpSTKMZFLPQU=
- Arc-seal: i=1; a=rsa-sha256; t=1728521124; cv=none; d=zohomail.com; s=zohoarc; b=f7yjk3EdyN3NE2za1qZxvdaQiZjbG7AkxeTOcKwRGcen6DkGTg/Evm7Xk2SRkq9mZtihz3OY0Lz9I7CTTbPHxToSayjcW3miVMLkS7w1+uTGJh6hk4PLMXhD3Cg+FJ5OZ0S4af67cg5RcgOeBBZ1vjXx0Po2mPnGiGtfOTB14zE=
- Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 10 Oct 2024 00:45:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/8/24 16:05, Jason Andryuk wrote:
On 2024-10-06 17:49, Daniel P. Smith wrote:
Add a container for the "cooked" command line for a domain.
Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
---
xen/arch/x86/include/asm/bootdomain.h | 4 ++++
xen/arch/x86/setup.c | 18 ++++++++----------
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/xen/arch/x86/include/asm/bootdomain.h
b/xen/arch/x86/include/asm/bootdomain.h
index d6264d554dba..00f7d9267965 100644
--- a/xen/arch/x86/include/asm/bootdomain.h
+++ b/xen/arch/x86/include/asm/bootdomain.h
@@ -8,9 +8,13 @@
#ifndef __XEN_X86_BOOTDOMAIN_H__
#define __XEN_X86_BOOTDOMAIN_H__
+#include <public/xen.h>
+
struct boot_module;
struct boot_domain {
+ char cmdline[MAX_GUEST_CMDLINE];
+
1024 bytes for just dom0 isn't too much. But when hyperlaunch has 64
boot_domains, that's a good bit more. But I suppose it isn't too much
RAM for a modern system. This is __initdata, so it increases the binary
size. I just want to highlight this in case others want to chime in.
I would prefer to leave it in the __initdata for now to avoid dealing
with dynamic memory at this time. Later, if a need to optimize for
binary size, then options could be explored.
The code changes seem fine.
R-b then?
v/r
dps
|
