[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v5 40/44] x86/boot: add cmdline to struct boot_domain
On 10/8/24 16:05, Jason Andryuk wrote: On 2024-10-06 17:49, Daniel P. Smith wrote:Add a container for the "cooked" command line for a domain. Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx> --- xen/arch/x86/include/asm/bootdomain.h | 4 ++++ xen/arch/x86/setup.c | 18 ++++++++---------- 2 files changed, 12 insertions(+), 10 deletions(-)diff --git a/xen/arch/x86/include/asm/bootdomain.h b/xen/arch/x86/include/asm/bootdomain.hindex d6264d554dba..00f7d9267965 100644 --- a/xen/arch/x86/include/asm/bootdomain.h +++ b/xen/arch/x86/include/asm/bootdomain.h @@ -8,9 +8,13 @@ #ifndef __XEN_X86_BOOTDOMAIN_H__ #define __XEN_X86_BOOTDOMAIN_H__ +#include <public/xen.h> + struct boot_module; struct boot_domain { + char cmdline[MAX_GUEST_CMDLINE]; +1024 bytes for just dom0 isn't too much. But when hyperlaunch has 64 boot_domains, that's a good bit more. But I suppose it isn't too much RAM for a modern system. This is __initdata, so it increases the binary size. I just want to highlight this in case others want to chime in. I would prefer to leave it in the __initdata for now to avoid dealing with dynamic memory at this time. Later, if a need to optimize for binary size, then options could be explored. The code changes seem fine. R-b then? v/r dps
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |