[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 22/44] x86/boot: remove module_map usage from microcode loading
- To: Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 9 Oct 2024 13:24:31 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728494675; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=NdsXFaL6OcWkddMVHpSZdgPigR1Y/THPyD/dSBYlqUc=; b=eV24x/1cffdolGbasniSq40+NwD/E308q7XsniCwMeqa0o+WoEzg9dW5fWrQwuf59yjpKpItdFKclHRoKfAIKNUd6cEKkvh57jT3O1AsIp6L6LyXHzQgg5O7G3k+0yj851aSMZuUR+lKqIjqHxs/FSZdCCYFZ85/3Z5ZcJECi20=
- Arc-seal: i=1; a=rsa-sha256; t=1728494675; cv=none; d=zohomail.com; s=zohoarc; b=ZGibqZ+b4NZeBcHCflhVaDA4A50lPBEo8WqTLaoAKc6fpN3K/kgui2OVfnVSS6ZXdNA11adsNQ/p8YOFcCi2yrpjScxhgQEKfHDeDaqnAxm77vY/7QD30N3dneI2tvLlLnXZitKdC60+RbG21MoauoajS3S2rQHez4vjEFMjrig=
- Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 09 Oct 2024 17:24:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/8/24 12:30, Jason Andryuk wrote:
On 2024-10-06 17:49, Daniel P. Smith wrote:
With all consumers of module_map converted, remove usage of it
by the microcode loading logic.
Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
@@ -202,19 +201,18 @@ static void __init microcode_scan_module(
}
}
-static void __init microcode_grab_module(
- unsigned long *module_map, struct boot_info *bi)
+static void __init microcode_grab_module(struct boot_info *bi)
{
if ( ucode_mod_idx < 0 )
ucode_mod_idx += bi->nr_modules;
if ( ucode_mod_idx <= 0 || ucode_mod_idx >= bi->nr_modules ||
- !__test_and_clear_bit(ucode_mod_idx, module_map) )
+ (bi->mods[ucode_mod_idx].type != BOOTMOD_UNKNOWN) )
Just
bi->mods[ucode_mod_idx].type != BOOTMOD_UNKNOWN )
Ack
With that:
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Thank you.
v/r,
dps
|