[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 23/44] x86/boot: remove module_map usage from xsm policy loading


  • To: Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Wed, 9 Oct 2024 13:25:51 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728494753; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=EK16H3fZfvQe0l1mL1qw8lvkCUbzkANqSSbabxoAHfQ=; b=Z7kWdGCFGctsORokotuCFNX5S9wjpNMBNfXxyA6KxEGqJsrhiMX8f+bKSfUxMl/bRUygRf8UEPQ1B38BEcMi/5AZcbeWQNrbllVBq6e2QtatwpcslBBvQjEOE7z+yDTz8g+vbSamh4gv0uAqg4dopqPg4QERgEipJECsvHVI+CM=
  • Arc-seal: i=1; a=rsa-sha256; t=1728494753; cv=none; d=zohomail.com; s=zohoarc; b=Ak3PigJZhRURLXwiJRboIg5D8obTxghR0aSF1bnovAGmnvPFdfSS1c1mMsePtEJVM7UTC1xIHBoH3wYH/uWaKdQINGQAC1LDfuaDN3DUOUjlHepzRwauJUEnbMFroXQUQdGSAT+H2Kk4Si47+uwHeblMt7g61Cf/qDIwCHUAFg0=
  • Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 09 Oct 2024 17:26:03 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10/8/24 12:36, Jason Andryuk wrote:
On 2024-10-06 17:49, Daniel P. Smith wrote:
Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
---
  xen/arch/x86/setup.c  | 2 +-
  xen/include/xsm/xsm.h | 9 +++------
  xen/xsm/xsm_core.c    | 6 ++----
  xen/xsm/xsm_policy.c  | 5 +----
  4 files changed, 7 insertions(+), 15 deletions(-)


diff --git a/xen/xsm/xsm_policy.c b/xen/xsm/xsm_policy.c
index 921bb254b9d1..a22367a62e93 100644
--- a/xen/xsm/xsm_policy.c
+++ b/xen/xsm/xsm_policy.c

@@ -42,7 +41,6 @@ int __init xsm_multiboot_policy_init(
      /*
       * Try all modules and see whichever could be the binary policy.
-     * Adjust module_map for the module that is the binary policy.
       */

You can collapse to a single line comment /* ... */

Ack.

With that:
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Thank you.

v/r,
dps



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.