[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 08/44] x86/boot: convert setup.c mod refs to early_mod


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Wed, 9 Oct 2024 21:07:48 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728522471; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=uHS3cMQp8xkM8h7cg1quP597bOWP2sRF49KObS84wX0=; b=OU1fddYIt83aTXZXRAX2uPADAMsGg3QF1sVAXnFyeG6q60baXJrxloXYeWiWClKL9DdDbMG7NyVztYUEfLsUlNKH5lqmAN0zC5aC1e0rmOxx8x0BLnJikWknHAnDUeaRsf8rAFP2aVjgUWKBKBxoNtg8tstlcRfM/b6YxmwfdYI=
  • Arc-seal: i=1; a=rsa-sha256; t=1728522471; cv=none; d=zohomail.com; s=zohoarc; b=Wzapc2H5edJqJx441lOiUVHJ7KGe3LKr1701yD44KrZ8Ve0iGYjUJiw2KWpLxtDE4szpyq/Q9WMX+ve5vA/XUO15QWSwDUGCGrooRvWuP2a3bqe9c1/NRafQS6a1ev+GC6L1xqV2iOt3lJMSBX0BkFQW+T7vSCmcrqO3ob8QsgM=
  • Cc: jason.andryuk@xxxxxxx, christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 10 Oct 2024 01:08:06 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10/9/24 11:29, Jan Beulich wrote:
On 06.10.2024 23:49, Daniel P. Smith wrote:
@@ -2061,8 +2067,9 @@ void asmlinkage __init noreturn __start_xen(unsigned long 
mbi_p)
       * We're going to setup domain0 using the module(s) that we stashed safely
       * above our heap. The second module, if present, is an initrd ramdisk.
       */
-    dom0 = create_dom0(mod, bi->mods[0].headroom,
-                       initrdidx < bi->nr_modules ? mod + initrdidx : NULL,
+    dom0 = create_dom0(bi->mods[0].mod, bi->mods[0].headroom,
+                       initrdidx < bi->nr_modules ?
+                            bi->mods[initrdidx].mod : NULL,

See an earlier comment regarding wrapped ?:. We certainly never have
indentation levels of 5 blanks.

Can format similar as earlier, and just fyi, that is a stray space from wrapping and not a five space indent.

v/r,
dps



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.