Xen project Mailing List

Re: [PATCH v5 09/44] x86/boot: introduce boot module types

From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>

Date: Wed, 9 Oct 2024 21:11:34 -0400

Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728522698; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Lg62GVQsE6x2aCxahcVNVYLttwIXT4Edl9jV2NaIpAY=; b=j2rcRz8lpZKhUynOUQM50rPQAe3TyZEd6PQrAfnKS1b6UDNhNMP1osyBQnZe06ZZ+m4sZtdFFcxxtNaVwmN034eXlyEW/tkRbD8hdjXZ9am35kXA1oM8WdUvHg9JSq+8EQSkLZ9NV5Q91w0rpMpVG4v108iwO7/QC83Fw/Rp/Fg=

Arc-seal: i=1; a=rsa-sha256; t=1728522698; cv=none; d=zohomail.com; s=zohoarc; b=dBeBfaDto9GNKdMVScVF9/0DwBi9njvZhyIc+sIMN0OvI7RoErL6uruogln1NNTNl5PhfLkgh7De4PJn6q8hJ3mu8tljMRmTcDDKrIdHzkEqyjYNT5XqXs6YHDq/D193eEMEoqXCalZTu7lNYCjo22loH1kpQyDvYuF4gAzKjUs=

Cc: jason.andryuk@xxxxxxx, christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx

Delivery-date: Thu, 10 Oct 2024 01:11:48 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10/9/24 11:30, Jan Beulich wrote:

On 06.10.2024 23:49, Daniel P. Smith wrote:

--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -311,6 +311,10 @@ static struct boot_info __init 
*multiboot_fill_boot_info(unsigned long mbi_p)
      for ( i = 0; i <= bi->nr_modules; i++ )
          bi->mods[i].mod = &mods[i];


This loop, on its last iteration, has done ...

+    /* map the last mb module for xen entry */
+    bi->mods[bi->nr_modules].type = BOOTMOD_XEN;
+    bi->mods[bi->nr_modules].mod = &mods[bi->nr_modules];


... this assignment already, hasn't it?

Yep, looks like I missed that the rebase of this commit put the

assignment back in. Will make sure it's not re-inserted.

v/r, dps

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.