[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 25/44] x86/boot: convert create_dom0 to use boot info
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Thu, 10 Oct 2024 06:41:04 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728556880; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Vk4Y92tpto3xRUB9BVwerBFdaFraJtDzLS6DK9vaRQ0=; b=J8g/JWmo6g1z5raRWJUNE78xNzubvJTERA8EYoEnIz/l8YsJMtn7gBV8ZlieLp1qCvbJcC3L7YfkkFa5kHlbKrIiHknx6bSs3Pc1TvxMtLuJ/UTCMp15NxXzBUw6hRs81ro/arbOC7higXs39q9xfa756YpAhjs4M9TIlTm3ZZE=
- Arc-seal: i=1; a=rsa-sha256; t=1728556880; cv=none; d=zohomail.com; s=zohoarc; b=fHL6xernUjRsjSX4fzyGa/XqYy+89zhT7v0uZFu/iKpbVSeHQg0jChMkzMTejT6/x1AhTVDejjj1JxoKQvo+zFf9avm2V0lV3nA+ygoxLZ03hIi5lpSXrPmCqifAFN9qPI64GMN2jIaY95U6KXIgVhvyKzbZLaHkUgx1gwcXHu4=
- Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 10 Oct 2024 10:41:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/10/24 04:03, Jan Beulich wrote:
On 10.10.2024 01:02, Daniel P. Smith wrote:
On 10/8/24 12:52, Jason Andryuk wrote:
On 2024-10-06 17:49, Daniel P. Smith wrote:
This commit changes create_dom0 to no longer take the individual
components and
take struct boot_info instead. Internally, it is changed to locate the
kernel
and ramdisk details from struct boot_info.
Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
---
xen/arch/x86/setup.c | 25 ++++++++++++++++---------
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 0d2ee19998aa..c2bcddc50990 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -946,10 +946,8 @@ static unsigned int __init copy_bios_e820(struct
e820entry *map, unsigned int li
return n;
}
-static struct domain *__init create_dom0(const module_t *image,
- unsigned long headroom,
- module_t *initrd, const char
*kextra,
- const char *loader)
+static struct domain *__init create_dom0(const struct boot_info *bi,
+ const char *kextra)
{
static char __initdata cmdline[MAX_GUEST_CMDLINE];
@@ -964,9 +962,21 @@ static struct domain *__init create_dom0(const
module_t *image,
.misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED
: 0,
},
};
+ int headroom, mod_idx = first_boot_module_index(bi,
BOOTMOD_RAMDISK);
I think headroom should stay unsigned long, which matches struct
boot_module.
Yes, that was not intentional. Will preserve the size.
And just to mention, with what was said on another patch mod_idx also
shouldn't be plain int.
Correct, and I would like to think that the compiler would flag a type
mismatch if I missed it.
v/r,
dps
|
