[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v3 6/6] xen/arm: mpu: Implement a dummy enable_secondary_cpu_mm


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
  • Date: Thu, 10 Oct 2024 15:03:51 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yym0EEggncFfOSUc233UEcJGav1crXKLZ4st43Tahts=; b=r7DmcetMhpT63fMgaPTXhdRv23jSZRK/phWc8WBGdSXmkQ4czOKOegBqOkLHH97lBeJvOd4CqN2WWIg7yKbTeAs5BNH6ENqsCx9amuLWc2Wquc9W16rEli+Eh2dZKMmoYxxgZyQql1Qwg/ssHTQcj7CeR0nAuyXAxfezDXGvBaYIbiqDsh+vajDJtlYJ+qW76oauRW8syxOxcuwxSNbEyPL53KGdD1ICMyUMankJbDQs8asA5H8eesmw4yW1QnfZBmpsWpEubI7ySPKL4W7qEsNBURIYkp3E5zIRcgtoC+PXaEMUfkrL71mhy4c2b9y3x8gX89YFe/bjffX3y5517Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b7ZF6A8n0zH7nv4XvOacBErxB9pZau3XFfW+loWWfoZxWmPIJiVh5oUpmlwi6RQC0xUzzST1lWb0wWjbDjfbppnFXbLMLRgPcmmKOtZ7Y4pFFqz+w1Qdyd4/dvnkXGK1gzHnf2+QHde7y4DqMTpnql9+Sph7zNeiRjqdE4YZDxORjKEVb2ci121Bem6XxOadqUBoWm5yTfP+hobvY2dlQYUv6ynf/vKM8Legoi3OwjdrC6jbI+kKS+5IbXYcU4TaHO79rSdsY15gZvuiZxJNmwKkFBe3cgpN24aaKaOXV6cbmH/6pQ8Kv3Pi1yzXqQfeh3dUsAqpcdJF+HspHshR3A==
  • Cc: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Bertrand Marquis" <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Thu, 10 Oct 2024 14:05:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Secondary cpus initialization is not yet supported. Thus, we print an
appropriate message and put the secondary cpus in WFE state.
And we introduce to BUILD_BUG_ON to prevent users using from building Xen
on multiprocessor based MPU systems.

In Arm, there is no clean way to disable SMP. As of now, we wish to support
MPU on UNP only. So, we have defined the default range of NR_CPUs to be 1 for
MPU.

Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
---
Changes from :-

v1 - 1. NR_CPUS is defined as 1 for MPU

2. Added a message in enable_secondary_cpu_mm()

v2 - 1. Added the range

2. Clarified in the commit message why/how we have disabled SMP.

 xen/arch/Kconfig              |  2 ++
 xen/arch/arm/arm64/mpu/head.S | 10 ++++++++++
 xen/arch/arm/setup.c          |  5 +++++
 3 files changed, 17 insertions(+)

diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig
index 308ce129a8..6053e048fa 100644
--- a/xen/arch/Kconfig
+++ b/xen/arch/Kconfig
@@ -6,11 +6,13 @@ config PHYS_ADDR_T_32
 
 config NR_CPUS
        int "Maximum number of CPUs"
+       range 1 1 if MPU
        range 1 16383
        default "256" if X86
        default "8" if ARM && RCAR3
        default "4" if ARM && QEMU
        default "4" if ARM && MPSOC
+       default "1" if ARM && MPU
        default "128" if ARM
        help
          Controls the build-time size of various arrays and bitmaps
diff --git a/xen/arch/arm/arm64/mpu/head.S b/xen/arch/arm/arm64/mpu/head.S
index e354f4552b..4d36a8c9bc 100644
--- a/xen/arch/arm/arm64/mpu/head.S
+++ b/xen/arch/arm/arm64/mpu/head.S
@@ -147,6 +147,16 @@ fail:
     b   1b
 END(enable_boot_cpu_mm)
 
+/*
+ * We don't yet support secondary CPUs bring-up. Implement a dummy helper to
+ * please the common code.
+ */
+ENTRY(enable_secondary_cpu_mm)
+    PRINT("- SMP not enabled yet -\r\n")
+1:  wfe
+    b 1b
+ENDPROC(enable_secondary_cpu_mm)
+
 /*
  * Local variables:
  * mode: ASM
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 0203771164..5a0d343f5b 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -296,6 +296,11 @@ void asmlinkage __init start_xen(unsigned long fdt_paddr)
     int rc, i;
 
 #ifdef CONFIG_MPU
+    /*
+     * Currently, SMP is not enabled on MPU based systems.
+     */
+    BUILD_BUG_ON(NR_CPUS > 1);
+
     /*
      * Unlike MMU, MPU does not use pages for translation. However, we continue
      * to use PAGE_SIZE to denote 4KB. This is so that the existing memory
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.