[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 6/6] xen/arm: mpu: Implement a dummy enable_secondary_cpu_mm


  • To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Mon, 14 Oct 2024 19:13:29 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k/KVuWsxVKGj2DiidtHTa5AbD05NG6u65EnAfFVF+5M=; b=mqLCe/N1db1Ui8c0iOg75Lr+nM87G28s6iEBWCvxP4XFt9YKkjgTcr7iEdZvLg3XN4pkYs2nyjz3LBJ3ivJ62U6g2FE46Zeo4H0O+hvdiVQomY8/NTxMCDMGwcfmRhET+AEFXZSG09IVzYR1/WZYSkiJCboqrxfdgBZXzmRNk11mIehDeIsiGqX6pWA/GU+IvaAcO03fpLc+YfW+mOx4cEDcqc6lIe6s3ZbZtEyvuXB8y2a0AeCReRGfPaLpDnjlijBZGeSB9SaRzHmpS7q7ZP1uCtqbH0vy5xrNQeAK2jW4ABWknYp9mXdWJMC3XlJcuJU6B8Z6i/d/l0/xAY1Ceg==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k/KVuWsxVKGj2DiidtHTa5AbD05NG6u65EnAfFVF+5M=; b=WUKMShR2puFYgp8LN+c2XoenxiZdQl18p1BprccX5NgkRi8iS2YzqiQsONAEDgHb6/XIq9ih/VVmW7prpBgUhbgw9b2IgH2Z6CyJeZgMiWFnK6zdzKAWq84jVRy60LQgDtZ7OjZ0fC6ZfXpu/Ca0Z+YWhqQohaIlkiDpg+9PKIMYDP7R8pLqs9sLt0lrCcWQin+yMjnjufy0ME3aMBFVMNIgO9B/mXsv6wKfxihIGSch+KahPPcx7BFUiBIYRVwDXm4LycIyz7L9dvv04HmGAWGxrVBfoURJJ5CyM9RajaogC9wAJga8B41mIDupPY4iuvQrKUUJVODSzKERoGlXDw==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=TXyjL3gT8k/BILyc9rw6rWn6WEAhXP0tABJKkQIxGAK8DqMip8yCrE1kzH7Vt9U0DmTytTb72TEwPnc2U2BXVZdz6dZ9I/WNe7SHvXx0Ud7BF5mjfOqKtrMWN/Jg0U/jErM/MrWriP+rGazexj9IDiFjIaWAUL7CpPsORKlIanTa3l6a/PP9W74CiSyv7mhBuoIEnwQ6Na3vGqOdvQZgXOyrGoNNO98zNfKq73SRAeMLCB08aaY1MdYJjdJbMetLkbEegMTBY3/xdk7c+BIpkIeOyXU+K7W3Pqf583Oz9tCmLkRC30tA+k4t+ioUoUvGLNXYGFG/3FNkCEekk0KF3g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zCo2X3W5EeMXwgus8GrkryIbV+xU0gFvIAdy2QLkKfa/exGG21bzp2Cdp8VfWmHFSNe6teCgpB5VKgl9KFBNzj0UpSFv3LW9/d0Qc/hwhqi7PF1LnUoCS1m/Mlnaf1xoAZL41P1m+jlyteAz3wozAKy2FFk7ee5esmXiUH5mzpum/nfQjejylmSg7MmPhNeGmrI3lec6QniL8tQoT0VWecP+/PHpZ/bLCuiiFnwPa631/M76Gh6XtPFrNbPM8TU28H7uwkK6EaevbOWXRlzWj9TLkRIy+qQFL8dKeUTU/N2ULxymCP31/YWUBFWiWz5XNjuIivAVArl828y//H4aRA==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 14 Oct 2024 19:13:51 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHbGx19ZodYjKVFWki3qzuo9dh20bKGpAaA
  • Thread-topic: [PATCH v3 6/6] xen/arm: mpu: Implement a dummy enable_secondary_cpu_mm

Hi Ayan,

> On 10 Oct 2024, at 15:03, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> wrote:
> 
> Secondary cpus initialization is not yet supported. Thus, we print an
> appropriate message and put the secondary cpus in WFE state.
> And we introduce to BUILD_BUG_ON to prevent users using from building Xen
> on multiprocessor based MPU systems.
> 
> In Arm, there is no clean way to disable SMP. As of now, we wish to support
> MPU on UNP only. So, we have defined the default range of NR_CPUs to be 1 for
> MPU.
> 
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>

Apart from Jan’s comment, the rest of the changes to the arch/arm part looks ok 
to me:
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.