[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 5/6] xen/arm: mpu: Enable MPU
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 14 Oct 2024 19:11:06 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fE7k2SmLLhqYbNviwomGEU/K/QmSH8pn9ExHoSq5SUY=; b=SClCzA8Xc7awVhW6NT3zPZKug+NAISCXyMFP95OE/fOS3JeTD2Bj0cwiODTUfynZki3npBuOYX2jU226JtlYSP47EGTpwPcugYB9dAXCG1KM05chxZGIWktgkhhUv7XoDTdT/+xxofUXW2pyrsmJdkYsA8h5npbNLOjDhuaE6A6AKHZVpkF/DqJEF++dBCFp5dEoMs/ONOd2komkrHHE9TSeYi+igJPGa9tsw872GzGKUGqeZB/iXX+Tz+b6h0n0SMlAb/vBPnSXm7oGwKDW8AbGsfwNUfXFEqnl8RkEu6t7TniO4ropQ6PglBB9eLLMle8WubR23fsU/cDvBGpDJQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fE7k2SmLLhqYbNviwomGEU/K/QmSH8pn9ExHoSq5SUY=; b=mPxzL/LG/MtSplUG9CTxpY56mvrBCVOYQeq3zYjof3cqX3mWHRk8W3hvR97vBqUd3hfALfFvI3brOHOhOAgu1YUgge/rEMBDE4rhENQ618p+7+TGkfbT7eJO30uowgUAWHqOu5sP8/E5ZZ3lENC0PliYPGzXpJyzC6tkqjRXDVjvoM0KbWWlbdOioF1TJ49ESL+iHDUg41ytMysBQQsdPloK+RF2IKFEk+Qqo2zj2vetrOcOJpVXS1HFhyR7Nq7GaCV2QUksh4my+s9HGvFwk1qi4gCfKov5n3nQd8aAjPj5sVPLtyHThEdvEqdlgnXpvtw6MWYqkv5yKv+Fjr855w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=sqqtUn06FTla6hBJmSokkPJWKMxMrBcMWDF96Z0OTu0YbyMTqDOL/N0P0Jvo1+x/JsA+8SfqvHCC9e8i9TNq9oifh17BGqmEvAnMU0E0072LYBrFCxpcmkXJV3DIFbTsDweQFascfFprbr6nHj/GoIwsFccMsL+2W9WuAHxZdMkA61hbBwR25dJZ9A2yvNsnzPRmkSSCHQk7CbA03sC7xdnsVvYaSpCeQvXBa9h68NadfH2CB18J8wGVrqSneRaY7JgMmxrq2LNEROReaoMvUpBotBILaqrZDYivTK+BjUVLTizBbwGO1WeTFt0klfiuQ7AYI6Jv39TdTucjTIFC9g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=srB3TUS5JcCsOa7UjwLNXuN+n+WQ5ngOfm10/Yq+ipUYppxupI95s9MgWsbJ/wsniWM0nIRCjK/3Glpf3cbvR2YazNNR/M2rRA4+VRxSPlqtM4RxT+KLbHlxAo4HIqAdGS0+3IH9L0xSsd9WX6JtoopOReYrsEmCowkt/s5A5FMZkSOGb/W1S5Wza1wgejTU6mWA++TQ/Q49GzV7AABysu4N7Phe/1Wkk9kjucxTu1iyYuqHUFKRy4eP6LFuaYE1tnzydy4o0PzUCAzLKqODf01Fhep4E6UjHxZvypLRwLJAcawINXFLE6+RijgQcT2TcS6nTdZBW55NY4VIU9GAeA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 14 Oct 2024 19:11:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbGx2Ge9N55hTx/U2iD9lYiTVQprKGo1uA
- Thread-topic: [PATCH v3 5/6] xen/arm: mpu: Enable MPU
Hi Ayan,
> /*
> * Maps the various sections of Xen (described in xen.lds.S) as different MPU
> * regions.
> @@ -68,10 +92,11 @@
> * Inputs:
> * lr : Address to return to.
> *
> - * Clobbers x0 - x5
> + * Clobbers x0 - x6
> *
> */
> FUNC(enable_boot_cpu_mm)
> + mov x6, lr
>
> /* Check if the number of regions exceeded the count specified in
> MPUIR_EL2 */
> mrs x5, MPUIR_EL2
> @@ -113,7 +138,7 @@ FUNC(enable_boot_cpu_mm)
> beq 5f
> prepare_xen_region x0, x1, x2, x3, x4, x5
>
> -5:
> +5: mov lr, x6
Shall these changes to enable_boot_cpu_mm be part of the previous commit?
The rest looks good to me:
Reviewed-by: Luca Fancellu <luca.fancelllu@xxxxxxx>
|
