[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 5/6] xen/arm: mpu: Enable MPU


  • To: Luca Fancellu <Luca.Fancellu@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
  • From: Ayan Kumar Halder <ayankuma@xxxxxxx>
  • Date: Tue, 15 Oct 2024 17:02:08 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d3STdeFXG/dPSbZJRVZQhBxxW1fuCYH3wF6eTLPrbX0=; b=S5IzuMaxNtdVtTE6yp0D5dLy1cb1TvS3WTyanjtnIhn9vsKDqioCZUzrceQpzdKWwslyKEIVSHQhv5YfiNAP45OAgnvWfTpcSapg1S4MxQhDkHw9sLvimZeFs7wtOxhg3uut92Y5gqSDJlPGuQd3AWzoBD2v8GAnEPglBpLILwDjYG22n/eGN0RVmgmIx0oQZrEPNPfVHcZfFwFwP41037Z0W9yPrr99AYPPTjymsiBiBNAn5YjOjxq8/+I0vJPxZWePt4ZPamXiFbeJV/U6eqxXii4UU6ZPxhhRp4UaHJlC+N5tW3DdYe9eYQjReGx+sd0OV/99/Huyc/4fORBaQA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ai/ikcrOd0jcAKlBXgJ7Tz9AQDmAC326sit/QZmwJMn78iE0hGjoVSDlpXNSxO1VRFIdpQgcJSG899YLj2bZV9YsPywB+2qIbd1eMaq7zxbBuD+aY4x7qKXphKVehQXzD2v1R9smiPDwSPQfqfc0+vzr9GZ2nCyp5hviq8hKKyxrWMd37XUV1K7jCkpm7ZpJ248L3sCok64FskxSmtAobw91l9EACtFDkOceXgGmLRQZ2VdY/Gu4mbx3HZKSqjElWT/rasDExU6IUqc7NSxE+cqqTbSfNNqXyFGBLevWDA+vtquyyV5nsp4Y2QlhtsFcxNJC+QmdzQixjMq0l0EoLg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Tue, 15 Oct 2024 16:02:25 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 14/10/2024 20:11, Luca Fancellu wrote:
Hi Ayan,

Hi Luca,

Sorry I missed something.


/*
  * Maps the various sections of Xen (described in xen.lds.S) as different MPU
  * regions.
@@ -68,10 +92,11 @@
  * Inputs:
  *   lr : Address to return to.
  *
- * Clobbers x0 - x5
+ * Clobbers x0 - x6
  *
  */
FUNC(enable_boot_cpu_mm)
+    mov   x6, lr

     /* Check if the number of regions exceeded the count specified in 
MPUIR_EL2 */
     mrs   x5, MPUIR_EL2
@@ -113,7 +138,7 @@ FUNC(enable_boot_cpu_mm)
     beq 5f
     prepare_xen_region x0, x1, x2, x3, x4, x5
bl    enable_mpu
-5:
+5:  mov   lr, x6
Shall these changes to enable_boot_cpu_mm be part of the previous commit?

This is why I had to save and restore the LR.

- Ayan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.