[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] xen: Remove dependency between pciback and privcmd
- To: Jürgen Groß <jgross@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Sat, 12 Oct 2024 06:50:14 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gTh8SS8fwzptYw7MXhoR0ymyla8OilaDJl9vy/dzxDE=; b=jpmcw7wn193hKETF528K53ecC4vO0mwn/m5ZgjvDb+eyiHWIYcJ+42IqO5/CPUbocmL52qmTaqg0ah9oeDIC9oh5QCFXhs94jT7SqlYB+BiBLRrzK/pizu3u49gQlW/n7XrSGslTjEXjqxFj6j9MUW39EXBuF+/GGZGllfjEGlybPeOfZeLlmdk7+9kU6oPTd1/kYPZjoxOpj+1f4fH3ST+zCucMVJyYEsfBUHKkZwckSxZnvvlsPx3z9em6oRsZAldTFc05HJ0/XdDixjS3ZdzJkvDtSK+sfafPykYheOwI3xqbMM1WCDSFxcSmqULgYArnz9bS7ZUB+dOJnZ+P8A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=s0Dat6gOX8REbKCzn9DdhYAYLYK6LfqSk1goePuGNJMuBu9r7O37UIxYRSruxRDumF31GjOPDymF+XpNjl//b55JHjqXNSvK931kZwRF8hA06QqaTc32zQFSwxX9ILoo05vZZznFFfbuTtGRmRnuIQ0ufNu4FtGJMHTqwmZ5HnRkQ5qz7Nwam4801Lr2CfwFneMGCT5o42GKnFtyACRMcMbM6lpXn5SwrZ16ObIt497aQoicuHKihXWQdhGPgchpRlrbuNZDx6LDiy6Mv6BktKtMfhAyRlsEtrZkXzZ2G9WH3OCsmuDIdZxNZdfdU5MLCCIWF1ti6JTh8a9QdOusvg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Sat, 12 Oct 2024 06:50:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbG4+3Lfp3cJlJ4UuqoaLQId+ES7KBdNAAgAF0qICAAAQHAP//sCgAgACWhQA=
- Thread-topic: [PATCH v3] xen: Remove dependency between pciback and privcmd
On 2024/10/12 13:48, Jürgen Groß wrote:
> On 12.10.24 04:36, Chen, Jiqian wrote:
>> On 2024/10/12 10:22, Chen, Jiqian wrote:
>>> On 2024/10/11 20:06, Juergen Gross wrote:
>>>> On 11.10.24 05:42, Jiqian Chen wrote:
>>>>> Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev")
>>>>> adds a weak reverse dependency to the config XEN_PRIVCMD definition, that
>>>>> dependency causes xen-privcmd can't be loaded on domU, because dependent
>>>>> xen-pciback isn't always be loaded successfully on domU.
>>>>>
>>>>> To solve above problem, remove that dependency, and do not call
>>>>> pcistub_get_gsi_from_sbdf() directly, instead add a hook in
>>>>> drivers/xen/apci.c, xen-pciback register the real call function, then in
>>>>> privcmd_ioctl_pcidev_get_gsi call that hook.
>>>>>
>>>>> Fixes: 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev")
>>>>> Reported-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>>>>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>>>>
>>>> Unfortunately I'm seeing a build breakage for the 32-bit x86 build.
>> Could you please attach the link or steps?
>> Then I can reproduce it, and validate it locally with new changes.
>
> I'm using the attached kernel config.
Thanks, I can reproduce the 32-bit build error locally.
And this "Add stubs for xen_acpi_register_get_gsi_func and
xen_acpi_get_gsi_from_sbdf when "!CONFIG_XEN_DOM0" in acpi.h, like the other
functions in that file do." can fix it.
Is it okay?
>
>
> Juergen
>
--
Best regards,
Jiqian Chen.
|
