Re: [PATCH] x86/apic: Include genapic.h in delivery.c

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 11 Nov 2024, Andrew Cooper wrote:
> This resolves 4 Misra violations of Rule 8.4 caused by the function
> definitions not being able to see their declarations.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: consulting@xxxxxxxxxxx <consulting@xxxxxxxxxxx>
> ---
>  xen/arch/x86/genapic/delivery.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/genapic/delivery.c b/xen/arch/x86/genapic/delivery.c
> index 7bb7bd658650..15100439be05 100644
> --- a/xen/arch/x86/genapic/delivery.c
> +++ b/xen/arch/x86/genapic/delivery.c
> @@ -3,8 +3,9 @@
>  
>  #include <asm/apic.h>
>  #include <asm/current.h>
> -#include <asm/smp.h>
> +#include <asm/genapic.h>
>  #include <asm/hardirq.h>
> +#include <asm/smp.h>
>  
>  /*
>   * LOGICAL FLAT DELIVERY MODE (multicast via bitmask to <= 8 logical APIC 
> IDs).
> 
> base-commit: 38febce5b35a7a4391906499b2046f01ec0129ca
> -- 
> 2.39.5
>