[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/e820: Fix parameter names of reserve_e820_ram()/e820_change_range_type()



On Tue, 12 Nov 2024, Andrew Cooper wrote:
> The work to address Rule 5.3 introduced violations of Rule 8.3 by failing to
> rename the parameters in the declaration.
> 
> Fixes: b5fd405aa381 ("x86/e820 address violations of MISRA C:2012 Rule 5.3")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Alessandro Zucchelli <alessandro.zucchelli@xxxxxxxxxxx>
> CC: consulting@xxxxxxxxxxx <consulting@xxxxxxxxxxx>
> ---
>  xen/arch/x86/include/asm/e820.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/x86/include/asm/e820.h b/xen/arch/x86/include/asm/e820.h
> index af90085d65d1..8e7644f8870b 100644
> --- a/xen/arch/x86/include/asm/e820.h
> +++ b/xen/arch/x86/include/asm/e820.h
> @@ -25,9 +25,9 @@ struct e820map {
>  
>  extern int sanitize_e820_map(struct e820entry *biosmap, unsigned int 
> *pnr_map);
>  extern int e820_all_mapped(u64 start, u64 end, unsigned type);
> -extern int reserve_e820_ram(struct e820map *e820, uint64_t s, uint64_t e);
> +extern int reserve_e820_ram(struct e820map *map, uint64_t s, uint64_t e);
>  extern int e820_change_range_type(
> -    struct e820map *e820, uint64_t s, uint64_t e,
> +    struct e820map *map, uint64_t s, uint64_t e,
>      uint32_t orig_type, uint32_t new_type);
>  extern int e820_add_range(uint64_t s, uint64_t e, uint32_t type);
>  extern unsigned long init_e820(const char *str, struct e820map *raw);
> 
> base-commit: 38febce5b35a7a4391906499b2046f01ec0129ca
> -- 
> 2.39.5
> 

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.