[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/9] hw/sysbus/platform-bus: Introduce TYPE_DYNAMIC_SYS_BUS_DEVICE
- To: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, <qemu-devel@xxxxxxxxxx>
- From: Alexander Graf <graf@xxxxxxxxxx>
- Date: Sun, 26 Jan 2025 16:29:29 -0800
- Cc: Yi Liu <yi.l.liu@xxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Anthony PERARD <anthony@xxxxxxxxxxxxxx>, Gustavo Romero <gustavo.romero@xxxxxxxxxx>, "Jason Wang" <jasowang@xxxxxxxxxx>, <qemu-ppc@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>, Bernhard Beschow <shentey@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Clément Mathieu--Drif <clement.mathieu--drif@xxxxxxxxxx>, Cédric Le Goater <clg@xxxxxxxxxx>
- Delivery-date: Mon, 27 Jan 2025 00:30:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.01.25 10:13, Philippe Mathieu-Daudé wrote:
Some SysBus devices can optionally be dynamically plugged onto
the sysbus-platform-bus (then virtual guests are aware of
mmio mapping and IRQs via device tree / ACPI rules).
This series makes these devices explicit by having them implement
the DYNAMIC_SYS_BUS_DEVICE class, which only sets 'user_creatable'
flag to %true but makes the codebase a bit clearer (IMHO, at least
now we can grep for DYNAMIC_SYS_BUS_DEVICE).
I love it. Thank you! This is clearly much more readable than the
magical hint swizzling I did :).
Reviewed-by: Alexander Graf <graf@xxxxxxxxxx>
Alex
|