[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [for-4.20][PATCH 2/2] xen/arm: Fix build issue when CONFIG_PHYS_ADDR_T_32=y
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 27 Jan 2025 13:51:34 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w0UngerHxIiVcYKEVBGoiv30EvIV7W3EgfyQ0zkoTZY=; b=McxXq6Xcg732FHY17gDH0eyKhjPznI+Nef6YPRzUhGAvQ+JVvJGmBAFxCl/pyloPQ/o8Lppr9TpjR6smGkOJ5NCk3+g5d1zSnR1Y2Ur8DS1dV73h+V7KFqgvyzRIEZkKKe7nGm32GVycFMktUYGIzr0X1XzvlyxTVODS4d+ETQdCQ4DHQC3MiGS+lgoft8zV3qx4wbx3wZQAx6dfHYZfatxvvkB4Yh/I9JYPjUWOTbx5KKl8ZuDVzJTBHMPrVpKZuOkrdknss7B7qrXdQeP9yunBdXXJwhw4pnAbabHDuNyril6R/q+nMaPTe+vViGaSlpnBS/DuO6a7MiCt9JPIIA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w0UngerHxIiVcYKEVBGoiv30EvIV7W3EgfyQ0zkoTZY=; b=bh2h5VTQrR/DtY4ooqgx4mFC6dCUgO4o52ZNWTSmZAKaEyCbbEMnRmsrpPZvCD+mFnyJWVGQ5UMGWSDHvdqaqo1IVDR19cNoMexUKUZNmCXiwiC1XsygVRPED+buxBvt6Z0K9LlKG6zQhXuj4HPJhFcpX6dh0bW7I3bKfPR4RlUEJ+ZACmwqdKuUpFcI0yLh3acJq6rY+NI0fnKt4pM/ff314qr97xOAw3LwXxxLzyZyyeo0EaYi+Ts1QUflAxFjyKRofNp8JuGc++8V7GNeMk++Bhu/UMnwKoOHxRRvx9swP6QMrWrS04qttqJpazcKh9+yOiFMqrPPIHRDldojog==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=nPFWPmGyq8HXOqDqr13xvYWCPwoHXiUqWTkmJX0ZVO2a2wzURBik6M8+s8bGtYxRUOJEODiyEjBEyqu6M/0thvjK5PapknOkQgLPYYyBi238dqdKTrkojw75Jy1Q0L0FFmjcNW+BecrUCMFlN9hvQOrZDrdvlDov7F7Biawk7j4XFW6+9MnSiAYB83eU6C+ZmzbeZS8K3u5yTCLdYPxEhTR9p2W8O+tmLb7faRGoYZxm0R6SnRHPY+P2wnPTlyFHYZJODDB5gVgvk1LiJXjjnH6CSJcsFgdU7F+6aX3go66vtvgSEdD3ovyhP3vx1IsOheFBT2EJiF01ymsqTn2jrg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FTENZ8D3VQOkXoOQfVHy3lgHP4hglD+bHbXZVhTrTjhdr0w3Gw1TsYvsuLUv6oBfjFwtfW3MfJPiNv9Ic59nqJOjDEyoUD1zokgihD0R2NEwxOqppZLbtA55FjGuf/G8yA4ufgwyeMXjIGYbbXb7FXjHougB9CodqTrsUUuS9+7ljNbZDajRq7uvSsjVdvnkZSWXe1+3UW5/h7Sj7zY3iavXenVrgFK4CW6V0rlGPydXtzf1JaCnNwETHFF+YeQhWD9ASIPQAb+y4RCTv2HCugd3+fs/Z30Rif+o5M3kdzJ0LRuuJ45fH7mHJFghRNEACvxNFi/3I/hxTYsn073uKw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "oleksii.kurochko@xxxxxxxxx" <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Mon, 27 Jan 2025 13:51:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbcKi5BZvZjkd9yUSyaUeahkEn8LMqo7IA
- Thread-topic: [for-4.20][PATCH 2/2] xen/arm: Fix build issue when CONFIG_PHYS_ADDR_T_32=y
Hi Michal,
> On 27 Jan 2025, at 10:45, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> On Arm32, when CONFIG_PHYS_ADDR_T_32 is set, a build failure is observed:
> arch/arm/platforms/vexpress.c: In function 'vexpress_smp_init':
> arch/arm/platforms/vexpress.c:102:12: error: format '%lx' expects argument of
> type 'long unsigned int', but argument 2 has type 'long long unsigned int'
> [-Werror=format=]
> 102 | printk("Set SYS_FLAGS to %"PRIpaddr" (%p)\n",
>
> When CONFIG_PHYS_ADDR_T_32 is set, paddr_t is defined as unsigned long.
> Commit 96f35de69e59 dropped __virt_to_maddr() which used paddr_t as a
> return type. Without a cast, the expression type is unsigned long long
> which causes the issue. Fix it.
>
> Fixes: 96f35de69e59 ("x86+Arm: drop (rename) __virt_to_maddr() /
> __maddr_to_virt()")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
I’ve tested this one and it fix the compilation issue on the above setup, I’ve
also tested
that it doesn’t introduce issues on other setup (e.g. arm64)
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
