[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.20? 1/3] AMD/IOMMU: drop stray MSI enabling
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Fri, 31 Jan 2025 13:46:25 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RS8pnDL1dA37YFpaS6K65r43e2EqQjnBbYBrBpOrdzI=; b=eRXqJpwPsJCY3oHH1ABGR6hi5isGqyzp7MJB6uZ2SQiIk3nJHjPe6Yd1YL1R5WM5sVoWj7XQKe+kAqSpMYCBYfTcHYw9DuJhrDOHs78j4i2s9p6h5CTYyGf4DxNlj0zFaQdZZPGe6P489ofekdTVElamB2CSPAVXruJ3L/KllyRLGQnMBU54Eq7zHxKlnOFkW5A+h38bIGWmj8BxNNlzvU+vZlh1ShEysbHqUBPtIlsGMVfW1k3c0oDPiGL5ZM0Yqg9JQCJt8pLfILGGp29m61SU3npuBxh/6gasIS4S0/sseot6Rnv+dqZH9C3AW9DilO+sGdZorq1vygYG3VcnsA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rL3du09rngXkUfki9OYOwX4p8LSgqJiquRLXnuk3oZNLXM4LdqPFzvTrm72yoCvbG0CR0vpaW465vtlP6eP+ww5G8J7DUBRNusXw2Jzjz7C4RPF8h94k2u8P0KxDRMgirrfhdeVVpnccfDoTu+MInLEdttllNWuri9pdNISL/acNcDCgYoWG6V1xNwZJqIRyr9bNWQWxREzxL6dGH3hFKwAi6AYcFA63FMcfBals1ipRqYRC5m/5LGRgT8BY0WIU6o2CSZUz5S2PK1EFC+xuu2p0RNCMAhfWk63rVULgx3PJXYnFb4Gs5RGg3t0t+92yyYORPsKtF4kVX2MlZpSYGQ==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Fri, 31 Jan 2025 18:46:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-01-30 06:11, Jan Beulich wrote:
While the 2nd of the commits referenced below should have moved the call
to amd_iommu_msi_enable() instead of adding another one, the situation
wasn't quite right even before: It can't have done any good to enable
MSI when no IRQ was allocated for it, yet.
Fixes: 5f569f1ac50e ("AMD/IOMMU: allow enabling with IRQ not yet set up")
Fixes: d9e49d1afe2e ("AMD/IOMMU: adjust setup of internal interrupt for x2APIC
mode")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Tested-by: Jason Andryuk <jason.andryuk@xxxxxxx>
dom0=pvh on CPU *without* x2apic support.
Thanks,
Jason
|