[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.20 2/3] x86/PCI: init segments earlier
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Fri, 31 Jan 2025 13:47:14 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jTFrcf6uapok3OVJO2hb0V0lbMc6AmfUzcGf5bxoiRE=; b=THDNjRlqKvZyzqvkF/UZfeK3WgWBduWYSWb5bneJyYdOq33Hr8uqVHWl2RTpO62K/64fEZatwSqzW0L1sHK/217GIpQRHFK/kgaFH03sf62PCGwBVoO+iOVASJaSa7NvVwXje5AcGBTXxBSan3alaXPo3OwbRfy1Sbw6tZNeBiz/h81/ounsC0Tf37qCdTB15goI3/uG7cJ9FyyJjUifbbKWYB5zcy4uLHqJBdFVjmn0rofTwe90hvU2W4Bc3iD1E+N/iMhVKfLmVz3hwLWskdRuCdW/VV+bdDEO1XwTwTga4Z0LkfHGVSPYXSsZ/RPGjtgJSGMeJKbzDGzaJYmjnw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DH/6HXrp8MZigRIBImkEq3boo9c1T14t9fsXIo5QVFvpX+E7MJvRdCPslXj5kdwbNFtmUj9VazMej46KqflLX4fdR9uigTBkfKPD/ECQiqJF6gkv7W90Y5ZC1G1XsFgPURC9EUquDXAsPn7G1cvs3oPTy2Li5PSlXdN3jUgblRdbWYVyB3H1iwC2WtC4dQNu05csANOsljsc8TPUjykidXqaI9lZQ0Onzc2rtaB+8q4vDMBteteUw9XlXmz485jzspSM55OlGrBrGydSWlCndscvT0nTDZzIjIUodH25ZXhuvvkSpPdgZ7Ymr571abfivhdf9lJ0CKApipGu39xeWA==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Fri, 31 Jan 2025 18:47:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-01-30 06:12, Jan Beulich wrote:
In order for amd_iommu_detect_one_acpi()'s call to pci_ro_device() to
have permanent effect, pci_segments_init() needs to be called ahead of
making it there. Without this we're losing segment 0's r/o map, and thus
we're losing write-protection of the PCI devices representing IOMMUs.
Which in turn means that half-way recent Linux Dom0 will, as it boots,
turn off MSI on these devices, thus preventing any IOMMU events (faults
in particular) from being reported on pre-x2APIC hardware.
As the acpi_iommu_init() invocation was moved ahead of
acpi_mmcfg_init()'s by the offending commit, move the call to
pci_segments_init() accordingly.
Fixes: 3950f2485bbc ("x86/x2APIC: defer probe until after IOMMU ACPI table
parsing")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Tested-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Thanks,
Jason
|
