[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/3] xen/arm: Move some of the functions to common file
- To: Ayan Kumar Halder <ayankuma@xxxxxxx>, Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 7 Apr 2025 16:55:01 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5rEJ+iPxXAe42dA7L7BcAV0Z4z1NmDsa561fHV6Pp0w=; b=NzgKmwY+vaq56tHC1qIT8f1bz0HCWUospGh0h3jIj5nVtjcQ/O+yb0UFI+aTutcb45n59oUiy/Sw9mzgfCSb42z7PzviqLDJoDmL6UpHNQKDP4Lr1iVesaqqIhVjZf0IA2EvJYqGM0JeqAk1loNHKkHzawDd7qaVUEybMn/yPoN0ZeW5G8HoEXSfOteaj2K1SVlKwFJ/pb8kIjhD2gNIMqOro8gFwN8Qf363dPKkiSRPpl+JUJSseEFKILWdulHDIbcLR6UGyLhwyDs4LLfAkuMYURDfu5UCcy6jkAyWsJV9Rv/M/PvzLK+X2iGsah2X70Vh75BuyaU2n71PwZ1YGA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ktTA9n74uMDs18plg4sd/ARFWJwYPOAHutjq0c9+H3oIjC32KnwYZ/LuJy9SelpEyOKyTv1pcqbRuPzzaJ/sk1/or5Y2PmJcoKWEW9Cp0ch/UoJ+rzNokgmHt48vtO9ElOwgqc92YT39C14H+9w5i7tj3+HU45Z3Tv6KJ7Th9oAuBbg8rmuJc32gDkEh6GpIfLayF2+Mj9BPKv9l2EUqS9xTo0RQ5B7ALFV64AxgddYXmgCxIi4RUf4OUKXBbhe1MP+ztw/1xZHsAZJJnJv+eOiYrZNlWOc1QQgshE+UkibY0K+JdfWPCEN1DwJASexO6RUDZ+lyjN74e0jA3nq5gQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 07 Apr 2025 14:55:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07/04/2025 16:07, Ayan Kumar Halder wrote:
>
> On 07/04/2025 14:31, Luca Fancellu wrote:
>> Hi Ayan,
> Hi,
>>
>>> On 7 Apr 2025, at 14:18, Ayan Kumar Halder <ayankuma@xxxxxxx> wrote:
>>>
>>> Hi Michal,
>>>
>>> On 07/04/2025 10:04, Orzel, Michal wrote:
>>>> On 03/04/2025 19:12, Ayan Kumar Halder wrote:
>>>>> Added a new file prepare_xen_region.inc to hold the common earlyboot MPU
>>>>> regions
>>>>> configurations across arm64 and arm32.
>>>>>
>>>>> prepare_xen_region, fail_insufficient_regions() will be used by both
>>>>> arm32 and
>>>>> arm64. Thus, they have been moved to prepare_xen_region.inc.
>>>>>
>>>>> enable_secondary_cpu_mm() is a stub which is moved to
>>>>> prepare_xen_region.inc as
>>>>> SMP is currently not supported for MPU.
>>>> This does not sound right. If you want a place to keep some common MPU
>>>> stuff
>>>> between Arm64 and Arm32, you need to come up with better name for a file.
>>>> SMP
>>>> has nothing to do here with preparing regions so it feels odd to have
>>>> enable_secondary_cpu_mm stub there.
>>> Can I rename prepare-xen-region.inc to mpu.inc ?
>>>
>>> Julien/Luca - any thoughts ?
>> I would say we leave the SMP stuff out from the common file, at some point
>> we could start working on the
>> SMP support and maybe there would be difference between arm64 and arm32.
> Do you want to duplicate enable_secondary_cpu_mm() in arm32 and arm64 ?
> I am fine with that.
+1
>>
>> what about common-cpu.inc?
>
> Sounds ok.
common.inc should suffice. Let's not split hairs.
~Michal
|
