[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/3] xen/arm: Move some of the functions to common file
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 8 Apr 2025 08:51:54 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=fail (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rX5SMfnGQQRj7Sok1mXkBaN9VVB+e2HR+LHp6LNcOXU=; b=aU+1ksvt9GyumJWc6zwqELs8HXk0Qdz6SYZaYpVTsVb/t8Pp2dHBRjCW8P3URPy7MGDtnyX5awUmnN164eHlpAJom53zxplX5aAJxkrb1vNTkuadgkcl1STFr0Wf9bSnEG+S/yaxfsWROCpQ8++xSPJ6xK08dLL9OOc1Tkz4/qwAIR/TUPc4Rw3RwwOE4oQPaH2gjDGCb9mj6zcGpWI7jWR3pUDJyKuTU7+CrRfmFJjX/tMPMQsWlAJKtbmkV66yw+2LstNtcPgbcXZ5KKD56ruxAu7katR4SBoW/Zq/2+dLsPCmB0Z9I7Kks5GiGU3GxY6aOaepvT9YGesLhC43tw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rX5SMfnGQQRj7Sok1mXkBaN9VVB+e2HR+LHp6LNcOXU=; b=InYsRLeu+uMWd09LSOXblAC9uFpoIpj0sd11oajzEVd9GBIELbCTPOB0X7mF1+NHexd9MXujceIe4NbKs2JE5zKzfiOBpSdZq2C/4uPebCtPxIHKekihlCcA7EoVCnAZvZqRJWzyDCSNqPLiauqgVqZENZ+rfFZm+xsy73+WeeMgx1fNKqRqD3U/BLiURSkSK/tRaaTFJUbs4owWfuwqpF/bYBKXUXy0OTJ2LbNmde3ptXaU0Si15OuuGXCmtrZj7Giy1/5fDsym3XWRKnUdU7NygfAYdDlLN7RxVvyuGK+cSHemCDoajuCFlSYHb5Og01mfLYDl0Q2/GF/6Bw7F6g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=GYoW/adiGzIpYkdWexESXNhXWAfPsfy+XUiTh7eQel3Oc3Tln3mNVFx7iGfDCsfubRWbpE5wIefIUFuD15b11AR2lmSlVV96/bwrI9vABtvfe5T5bgO8Alz+/OVU5E5Mr7UX9iCQYUUeXUwMcZIl1RbQQuYjrygIt2B5m/oswksubdnRmQZeFReGD27quBZqfBHUZ3FeD6/bQZ65H+0UX4ZA6ioyOevqNrSfYqewM2EHfdA8Dybz6VNn57nxF5RrFQD6SxMfRygCHBHyTBwgF5PtlgqXSPMYvYKP90hvhbLcgUHpGUm1l3XqzG2L3hsJwy0I07y1HY9uAHi6Asm/rw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vUIWSQlrzCtR+QHat0nITifJK6RnIln+OD7Vym64BiJCwsFfUNUEl4MAN6oPna4tsh/Pdc0mPHCbzfGyKLa6+iwzTuTp0Z0G8UFYagTWAp2o2n51P3i3sE+bMvWhFJ672hCbIFTQuMjxFlUsi1CGEb3tDoBh5wZ3QrxEmdkra0M9lZb5++vFNIdeYzMWjoELSLMkHJR5e2IGKfzwoff3BnzHR8vWtQq46ao1UkI113IKgKy2HkobVmS1UIzj33sKpiOUub0t2kmth/blvyelh2GVzET6E8K1gS7y764TILHvBHMjRhgUf94HyJJ+iADWJEa53nNZ93ID7AUSgDA+dg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 08 Apr 2025 08:52:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHbp+1Intz3ipmah0uCxwQ9Q6LVGbOZdvUA
- Thread-topic: [PATCH v5 1/3] xen/arm: Move some of the functions to common file
Hi Ayan,
> On 7 Apr 2025, at 19:44, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> wrote:
>
> Added a new file common.inc to hold the common earlyboot MPU regions
> configurations across arm64 and arm32.
>
> prepare_xen_region, fail_insufficient_regions() will be used by both arm32 and
> arm64. Thus, they have been moved to common.inc.
>
> *_PRBAR are moved to arm64/sysregs.h.
> *_PRLAR are moved to common.inc as they are common between arm32 and arm64.
>
> Introduce WRITE_SYSREG_ASM to write to the system registers from the common
> asm
> file.
>
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
> —
>
Provided that you fix Michal’s comment about file name (even if
{mpu-}common.inc is more flexible and
would not need any renaming in case additional code is added that doesn’t
involve region manipulation,
but at this stage I can’t foresee any) and protect the asm macro:
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Please keep it if you change the code for the above comment.
Cheers,
Luca
|
