[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 08/10] vpci/rebar: Remove registers when init_rebar() fails
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Mon, 19 May 2025 07:49:17 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YRuy3wektnG2j1QDmSmqn7HZ7BnVThQbQrgg1+poX4Y=; b=b/soKVF7X+fMntZ+NAkrxL8ODcjVrFaJAQBpXZl/kNOPMfDqOo79JuO/9k5zGaPI9HkQbGn9+fpCqbCUY/YLEClqFFPEWecGfH8Q8tLyyguPUxwwkpwUSA2oKTmKVFZrm5V6SH4swlIGzxsZu4ESTAy3Jzwiuny9byBmoAZTeB/U1Du+N2x0ktsJfNMNIYK2Uks7QZ12UdhwZE6vajSH0iOe5/sYpmxRGsPGVDYGlEMAmDaY3YkvufSOetsXDZVkxUjCcVtcGQmitxJiXea0zTPBmQ4UY1MH+G7TVZWLG3VXHSKVJHZxCWYi1coByNKhWW0p7a+20OtylLJYoyA79g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NX/uxJl2EMtyqnP6EqyFSDs0MSiP3zUCz5wJG4zpR5MOvJRw/w/N+7fCFL0UIFgoqZdzus31mSvfVa/9o/Jg+U9D8sNzUsHtL2TWbVSyh0ORvf4XSB25J6Lz4JZGoeNvNqDSRkfgmI+zh+H7uNROAEaAYe3KHHEeXYVnIPiHd/nB2t7/QvkTOa1UYvxr6WLNBvnvrh6kCjpsm8JHlMSqGE/9qiDg5R6NTs/h6vWvaCNTo7KSehuGqOj+1VCo/BkHuiSFPLgHiqIChEldGAsp1Jy2oEdrMloyKzj68Z+OJtAGq6JqagUe1ezWZO+69E4tZSpXBwDR3wplUlEXBHQKjQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Mon, 19 May 2025 07:49:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbwMGht1D1H8X23kq6XrWFn0smo7PZlEAAgACVAwA=
- Thread-topic: [PATCH v4 08/10] vpci/rebar: Remove registers when init_rebar() fails
On 2025/5/19 14:54, Jan Beulich wrote:
> On 09.05.2025 11:05, Jiqian Chen wrote:
>> --- a/xen/drivers/vpci/rebar.c
>> +++ b/xen/drivers/vpci/rebar.c
>> @@ -49,6 +49,26 @@ static void cf_check rebar_ctrl_write(const struct
>> pci_dev *pdev,
>> bar->guest_addr = bar->addr;
>> }
>>
>> +static void cleanup_rebar(struct pci_dev *pdev)
>
> Just to remind you that any hook functions need to be cf_check.
Thank you for reminding me. This is my first time to know this.
I will add cf_check for all cleanup_x in my series.
>
> Jan
--
Best regards,
Jiqian Chen.
|
