[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm/vgic-v3: Fix write_ignore_64's check in __vgic_v3_rdistr_rd_mmio_write()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>
- Date: Tue, 20 May 2025 15:17:01 +0000
- Accept-language: en-US, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l/dAQhVDkTasaRwPrHbblfY4HhPB4oXdRyzNzs1H/Pc=; b=EaAAAQp+qZgZDFZ1le21qkzkNfkkDZrEoSKzh6ixQ65F2+nlFSi94YwlIVNophODn11nhdlW3ydjlQJWGUjslDwXCbOxCg8tpiM8WRr4yknbwzLPFk3WY4jd4aTMxkDu0FDKnOECvPkWE1zpEeacUCQR/guq3hsu7LYbUon1HBkfJJd54EOW1gemPTMcwRKlWtT1RquaPu8nu3eXud40hqfx+zGtpzDNWf6BVjsZrjttWWqtsehlxrZOw9gk2C2JPhhWDlGAspuQNliSDVcVScnZKIbMEH2IyTjrrHOvfWpJ90zsdBUhUrNlq4zQCDAWPFRylQXvQK2qvQ7xbh8Rsw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Hspkuzk0zkiF4rLgDCwpp9Di90oHBxD7B0T2wKgAUQRgyHEiA3kado8YCrSwEbgvTOxGjo7Lz3V1lPeXTbhakT1xHLwzCKMYqy9DEZzKzjRt8YW27UkE8X59POwz3odAJv08trERk5KSiFkT3o++/P9oI57l40gWRLdvvCk+zj0NLoGHKa+EhoGSara5estQ7ycuS3gslEsvwZS5Z4s71Dsaym3pUrUdRQieubIyMAOsKWGCysKnfqO8rtqKZETTFioAghbvbhmA71rfiX6RLxEMQoft4tX8nJOhr0qY3G5FCue20FDJQk5z5O5SzjlHgOVF/OYvC0yHxFdnMIGEtA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 20 May 2025 15:17:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbyY3It6QrN0GxI0mChLdwI1GDxLPbksCAgAAOmIA=
- Thread-topic: [PATCH] arm/vgic-v3: Fix write_ignore_64's check in __vgic_v3_rdistr_rd_mmio_write()
On 20.05.25 17:24, Andrew Cooper wrote:
Hello Andrew
> On 20/05/2025 2:47 pm, Oleksandr Tyshchenko wrote:
>> An attempt to write access the register (i.e. GICR_PROPBASER, GICR_PENDBASER)
>> which should be ignored (i.e. no virtual ITS present) causes the data about
>
> Do you mean "data abort" here?
yes
If not, I can't parse the sentence.
>
>> due to incorrect check at the write_ignore_64 label. The check should be
>> inverted.
>>
>> Fixes: c4d6bbdc12e5 ("xen/arm: vgic-v3: Support 32-bit access for 64-bit
>> registers")
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>> ---
>> xen/arch/arm/vgic-v3.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
>> index 2eaa48fadb..b366b046a2 100644
>> --- a/xen/arch/arm/vgic-v3.c
>> +++ b/xen/arch/arm/vgic-v3.c
>> @@ -649,7 +649,7 @@ bad_width:
>> return 0;
>>
>> write_ignore_64:
>> - if ( vgic_reg64_check_access(dabt) ) goto bad_width;
>> + if ( !vgic_reg64_check_access(dabt) ) goto bad_width;
>
> As you're modifying anyway, the goto should be on the next line.
ok, will move
>
> ~Andrew
|
