[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm/vgic-v3: Fix write_ignore_64's check in __vgic_v3_rdistr_rd_mmio_write()
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>
- Date: Tue, 20 May 2025 15:22:14 +0000
- Accept-language: en-US, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X7DJWiPDJy5PhRYCIIt7cSltDC5ZIuEapP0V3N+U8G8=; b=y1mKHNXD5wMNiO9FVLGEFdOziI5VrNvOrWREJlPC2tHyUscAK7ixfIhyFPkmRz9fFserxTGCTZEbCz6J1N3tRuiQ/mMFmsixs+saXSZUVK0ZqGay/I8Dlj6Oz9sj66OAhRIRxCnQXKPkd++lHBYH/l9vAmnxQ5kswvt+wbuxBsAD+d8ilqXQxfw5bvU0Eqf/XGji6BnBtHYrkEnsxBZFyFnhQGG4pyJY/cGud1rFVhfb/w2yFcXXkPOQ+0Inz+laSduikycA9l8gxMhH7wbP878njtYqanjV1jESxCkA7FYGDnHnYuCBd9FSqKhM6rtS8c5/E/V9TIwRzwyIuzJdcA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iBjvGbu/0vmUtunntwx9tn67GFW2jT+88JyiNxyrDhVgQOWbJ+IqVzkLZGfzEwg0IOH9a4Ew3sPx9pucWrsqkjp218Jgbh4VUbAeJakVsgb3YyR58FF3VAVtc5ehpVNKmZBRsOjlRJr7s/DbvXFiEym5pFg9sVKohYZXlObOC/cm1QFl7dNXbxKh1g2dNnbrS3UuSowa1ORNEk9bQjCN+eUZqup9OKQ4PQSHLgim93MjmmBELidHlvvNo9X+G20lHNeGzSPXcndNkw4Xmd7noIV5eqs4JoVUdacEZKYeQlwyJ/sPrhtZlmhxETgzcEHMWBfTsRtzEGIByijZgBDOHQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 20 May 2025 15:22:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbyY3It6QrN0GxI0mChLdwI1GDxLPbnUIAgAAFjoA=
- Thread-topic: [PATCH] arm/vgic-v3: Fix write_ignore_64's check in __vgic_v3_rdistr_rd_mmio_write()
On 20.05.25 18:02, Julien Grall wrote:
> Hi Oleksandr,
Hello Julien
>
> On 20/05/2025 14:47, Oleksandr Tyshchenko wrote:
>> An attempt to write access the register (i.e. GICR_PROPBASER,
>> GICR_PENDBASER)
>> which should be ignored (i.e. no virtual ITS present) causes the data
>> about
>
> I assume, this is a guest data abort, rather than Xen crash?
yes
>
>> due to incorrect check at the write_ignore_64 label. The check should be
>> inverted.
>
> OOI, why would a guest try to write to GICR_PROPBASER if the ITS is not
> present? Was it a bug in the OS?
no, it was just me experimenting with redistributor registers.
>
>>
>> Fixes: c4d6bbdc12e5 ("xen/arm: vgic-v3: Support 32-bit access for
>> 64-bit registers")
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>
> With the commit message clarified and Andrew's comments addressed:
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
thanks
>
> Cheers,
>
|
