[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] arm/mpu: Provide access to the MPU region from the C code
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 9 Jun 2025 09:44:00 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LbZq1FlxOZLsXAQgS6CVyajnSwlb5nFirlVj6n4k11U=; b=CPkpb5FThayMWbhg2up+z3A3AbnxHGsNqTNqm8nS2ods3b2fdA5bacuL00lB7r90KBg6dsMx6Zgw+5gXT0Q1yfvnDdj7YPCdXO6dDBwnyb+5FBHpMemYtMslKGexQN+Bi4bRrU+NfnMzF8RaEs7j4dve9QWjRKM2zyX25x01S03HhKzkcZvqM0d9sr4mFkue4X++bdB85hGmQSM0/FESZkExUP3jdyLdeyh6COjreMi23lQmEWoY3piuBHk2x2rEEF6LBXbDIZJUBfBSfLTAzEszANtERXnt2gSoIvic3vTkN+NPetMTY4/IoDWE49fwC3kH/Y41hm8yOkk+D6LdHA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OojlPjAIyureiYJdgeLVSLIlhCiKfYjYeIfzHstzYlrNhu2Bap5SGHTYFKKfMn1gcILBnBIzvEct48czcrln8LPeFdL8zyFXWzsTyHr3k2hxHVqXhsmvtt8iaMit9ptvcgfoqwwAAwwiZlTF/Wm+BgGJ3h92Dxj1kAPtwFcfx5KiVRQMkFHUclYGDyLW8keuosGX2oR8zK7937Bm9FcvEWT26w58BPFUuZ/sEUWjPUwZgYgc6g6NFNFjvcVe9u8YLCd45y7BrXiNKtn3leASIcoNYGpSNlffHhZncqUkn4iLyiuLtbb00PNrVtEnEnS67Hcn1XK1NJfnY7N9bDjMqw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 09 Jun 2025 07:44:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06/06/2025 18:48, Ayan Kumar Halder wrote:
> Enable the helper functions defined in mpu/mm.c and asm/mpu.h for ARM32.
> Define the register definitions for HPRBAR{0..31} and HPRLAR{0..31}.
> One can directly access the first 32 MPU regions using the above registers
> without the use of PRSELR.
>
> Also fix the register definition for HPRLAR.
>
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
It looks good apart from ...
[snip]
> @@ -98,7 +101,8 @@ static void prepare_selector(uint8_t *sel)
> WRITE_SYSREG(cur_sel, PRSELR_EL2);
> isb();
> }
> - *sel &= 0xFU;
> + *sel = *sel & 0xFU;
this change. Why?
Apart from that:
Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
