[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 03/14] CODING_STYLE: Custom type names must be snake-cased by word.
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Alejandro Vallejo <agarciav@xxxxxxx>
- Date: Mon, 16 Jun 2025 13:07:30 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sLdGv+fG2t86tyUle0iGrYvhPoWrKjMYUwUgcNk5+DU=; b=HvWM2wPdjF54BWg8BQNITGb8bR72ljk3vPEnttCr/Anv4CZv9afUJjkedSENDkFUbVojU96S5ThIjPFIvyp+V8IF/cKt7H15oresoIYQtamwNmew1Or1VMM3shC3VtYbJEdowdzwSAQt/QQ4ly4hwYRs0DfIbyJ47ZRpC0N5wXAzLdWrZFkMO60blJ9G0URILx5gg454jWB8IewWYo/RhVzODStrYJBQ/V7XYtH99jzU7O4Ga6oUO0k7qlMKCdn5ucvSf2Vsqilp9B8LY9fA9Nfp9CrpC7lwvlVVMfMcq0JL7sl4e7FZoKMLFCr8P/wbwaS7UCJXrVlpc9YmJhCSYg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RHbHfxGo22x9DZXgmAOSYIxV0hR0+qYqVrc1EJ5HiXH/xsyKYxWdMBltnRKd2EX7tzEPBuX7lWWW/iF+QSIUDN3ewmGoD4YI1OQo7emxCEfbSxScMxoBre5swrB6nUmJuqdOVZR6MlOrLr5CLMSWkxehQiQjMwHlp6fTbLTHSqk0aAqGSkjgtrTwE4ZjmLf1Xas0Z6pUh3XFe2DUtr1lRgjSQxjkX1MJj0n0MHmj13/bPgVOnOcXxnWykOiqe8BljITAAJRFutaaoysEl2ZRhjOSHITC+rfxht85EQlAQg9l0AMZzVzjlVNHuC/Xr046f9kEwmB7H76+R88Ff06wzw==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 16 Jun 2025 11:07:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon Jun 16, 2025 at 8:48 AM CEST, Jan Beulich wrote:
> On 13.06.2025 17:13, Alejandro Vallejo wrote:
>> There's the unwritten convention in x86 of splitting type names using
>> underscores. Add such convention to the CODINNG_STYLE to make it
>> common and less unwritten.
>>
>> Signed-off-by: Alejandro Vallejo <agarciav@xxxxxxx>
>> ---
>> CODING_STYLE | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/CODING_STYLE b/CODING_STYLE
>> index 5644f1697f..e91ef7b3ca 100644
>> --- a/CODING_STYLE
>> +++ b/CODING_STYLE
>> @@ -126,6 +126,9 @@ register).
>> Especially with pointer types, whenever the pointed to object is not
>> (supposed to be) modified, qualify the pointed to type with "const".
>>
>> +When defining types, split its words using underscores (e.g: prefer my_foo
>> to
>> +myfoo).
>
> Why's this being put in the Types section? This is about identifiers, and
> ought to not be limited to the names of types.
>
> Jan
Because the existing argument had to do with type names and I wanted to limit
the blast radius of the new rules on architectures that don't currently follow
them. I don't care where it sits or how large its scope is. If others are
equally happy to generalise to any identifier, I'm happy to do so.
Cheers,
Alejandro
|
