[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 03/14] CODING_STYLE: Custom type names must be snake-cased by word.
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Alejandro Vallejo <agarciav@xxxxxxx>
- Date: Mon, 16 Jun 2025 13:08:34 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tML+fkkAsla4oagPUJMuFrBJe7qpUjDyEplBx4E4ySA=; b=qXFWa/cpWM6GtVQq2pHa+H7oOIOrDAnHgfFqAYVdm4sfOOA062Z2P67rFFZ3jOIFVHy2dJ6+dfW6IGBcps4rnw+tuRO/I8w+7Uw/hRz/JFU0U8SZYrvLTO3VwrF0ZupW70qEiy/2BpITSlkaWUT5o12hCS9UsryV5w/cawnYgC0aJwtl9983RSTBpnGKbCYt/So7tKjs41/KiFDldX5tZfpirvSK6KaJ/DmH61sIhMYTcPGuWJPfNKwDMYYuJ0SEmk/e/sOfJg+Ee7mhtQH4bBYcO3HWXRdQkm/yhEMnR7M+hHGiUtt0cNK6PXSjw80G1jS2U88mw3/NipTqQBSluw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SK6NaSTzE9BJ2jTs1Hn5ktTRUziVDCMWd6SRqkp1jtD8cyykiQKnq9WtekHxYVYMDzDJHPcLehVwLKsT5eQZIbhrVeJX1ZqqsS1W7IaEVBzz8Ev+MQpv3D5aOe/H07tFA8kyCGoMD1h1K3GBg7lUTeQLtGcMjfHQpDdqVzRTYmY3Imsh6SNSa5Ex8wyHSCpLHioAllcsB/62fklQ1wclS3THgfOXNjdThl7HZT0hGHAi6Z27elI7iQbxkwfaU8nAhKbcP+6LAa7oaoQurr5Z9jlnjqKkuzp6Lk84qy0Zi1r39joCCX/6QCe86EfsDsAmfx1YN/bwu6OWRCCP1ovddg==
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 16 Jun 2025 11:08:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Sat Jun 14, 2025 at 2:32 AM CEST, Stefano Stabellini wrote:
> On Fri, 13 Jun 2025, Alejandro Vallejo wrote:
>> There's the unwritten convention in x86 of splitting type names using
>> underscores. Add such convention to the CODINNG_STYLE to make it
> ^ CODING_STYLE
>
>> common and less unwritten.
>>
>> Signed-off-by: Alejandro Vallejo <agarciav@xxxxxxx>
>> ---
>> CODING_STYLE | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/CODING_STYLE b/CODING_STYLE
>> index 5644f1697f..e91ef7b3ca 100644
>> --- a/CODING_STYLE
>> +++ b/CODING_STYLE
>> @@ -126,6 +126,9 @@ register).
>> Especially with pointer types, whenever the pointed to object is not
>> (supposed to be) modified, qualify the pointed to type with "const".
>>
>> +When defining types, split its words using underscores (e.g: prefer my_foo
>> to
>> +myfoo).
>
> Minor NIT:
> When defining types, separate words using underscores (for example, use
> "my_foo" instead of "myfoo").
Fine by me. That's clearer.
>
>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Thanks!
>
>
>> Comments
>> --------
>>
>> --
>> 2.43.0
>>
Cheers,
Alejandro
|
