[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 04/16] arm/vpl011: use raw spin_lock_{irqrestore,irqsave}
- To: dmkhn@xxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Wed, 25 Jun 2025 08:52:39 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VKXHAIGeMQ7sxRSWLLIKNAIWYJaNR/hChrkaKJBDn14=; b=ix8D9vLr4BFD3Rbm+cDF4DcTpwAnzGYYb6Dn5+oIqcIobjgxvuro/l/7OnPWGU5E29t+cNI9PXDDVNwvTTl59+NnjsenyzI54+0Xnlc4VLgQW5XP4fyTUAwH4ug9hikt60R9RM/ohiwLQHKU3tk+U8W8ffBDVjkSXj4NBwh6nS5jhAkCMXvE1M/6rmQ4bSZB46FS9SYRjh4vDC2FSej/3tcyX51Olu4MLTXFv67s+I4eQ09lNfogrHDucwpRyoKevCfU2WViV2lyMCHbTvAeIDseEMOqWcJ+0HWMkrvdOtF0wPrvL2fHAgJ4uQlvka1H+TF7yDIDMGMF/2N2/N3J2g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fWwfDRPYh2wnT3c4AGVgZXWNttULiz57/YTKvEepFjTD5jetWYATqaK341si17ia9o/E7lsYJDfWOQmkuqfEfhR2MNLNvhgShsbEVMVOE8AgWz9IOfbhpnX7+PiohCDg3Tb/FvPxdoiYWgwvZssoIH4shVGpB4HN+asFWKZwSAfxp6VSiVzaIkc3UZ/SFieyf9UEx6Iijf+udvb2KqbhRTNtf+zfIs+Wle9j/U4QnaPqbBDj6SYyVUfXETY6IBoNGtf1EnsXtJ/dhWMYB1FA+9spuIOnKI27TNKEcBEhSVi68SwIi3nvN9txj43cBQwr45uwWE4+bZMS1KBou25HHg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, julien@xxxxxxx, oleksii.kurochko@xxxxxxxxx, roger.pau@xxxxxxxxxx, sstabellini@xxxxxxxxxx, dmukhin@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 25 Jun 2025 06:52:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/06/2025 23:46, dmkhn@xxxxxxxxx wrote:
> On Tue, Jun 24, 2025 at 09:50:54AM +0200, Orzel, Michal wrote:
>>
>>
>> On 24/06/2025 07:46, Jan Beulich wrote:
>>> On 24.06.2025 05:55, dmkhn@xxxxxxxxx wrote:
>>>> From: Denis Mukhin <dmukhin@xxxxxxxx>
>>>>
>>>> Replace VPL011_{LOCK,UNLOCK} macros with raw spinlock calls to improve
>>>> readability.
>>>
>>> I'm not an Arm maintainer, so I have limited say here, but: How is this
>>> improving readability? It better utilizes available local variables, yes,
>>> so this may be a little bit of an optimization, but otherwise to me this
>>> looks to rather hamper readability.
>> I agree with Jan here. I don't think it improves readability, therefore I
>> don't
>> think such change is needed.
>
> I think exdanding macros helps to understand the code since is explicitly
> shows what kind of locking *really* used, so this aspect is actually getting
> more readable; yes, that's a bit of more text.
>
> But, MMIO-based flavor does not define such helpers for example, so now vUARTs
> follow similar coding pattern which is easy to read/follow.
I understand your point of view. It's more like a matter of taste here, so I
won't oppose to it. Others may chime in.
~Michal
|
