[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 02/16] arm/vpl011: move DT node parsing to PL011 emulator code
- To: dmkhn@xxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Wed, 25 Jun 2025 08:57:27 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qvYenQp3ahDHYQWfOgVudhzSrs6/DFyVHKXFxpepVEE=; b=CIJmQUHOrxJknVMp6m80iheg7zHcqEGyHVUR85PXazyyWAS3DRbVXBMvwxqlkKEpLMn4ISweXh/So3hhCXOBJcQ/6e/N64Xfa6Xb04/LqvBdRr4qKSZfxtQkKcKAq0W38l9m019HhBzblwNG6FfaquMM/Jsf4Jsq4HdCNbrzaE12feJC96IUB63U6grOxNdqyi1ASHCXryaFTqjejiZPI8tSAe74PDW7gzxdgxQGcPpNz2tQsMal6B3AOddeKsSujCBwKxT8ta2Fba13ESHHK75RJcYhwjFRZvVFOWgGm/5qKXUdMqMStuSR/O+6LzBLC+pvt+krrjRHd2WRKtWoBw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qHaxt0EsBnzpROHa5YK41CoaPP1MgtuwpbyOtKUGkrr4sck6kPgjJurzmDDGxXA1I451lrfQf0qL/ZjmK18of1cD++fvpuWV2f7XykgFp5KZMJGMain2lemIr1kF5EkXHhqE50BVpAViupPj6iaWqfgqksE9ahw8ndVq92qDTriOSO0ONh+am1Xum3JNqcke5qTTcLN1mHlmlgfu6MulD4IMlvlgrhh6QCJUqMmZkWZjf9pyR9FUCUCsLWu7Ex8bA6b7tRFLYhhbJK/qmCtWSUkGbxushylXVUPotQLzK7EzOrrQnXNGTwUdpKgfFsFBz8ykViYDJyay1GqyM9sPmg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, jbeulich@xxxxxxxx, julien@xxxxxxx, oleksii.kurochko@xxxxxxxxx, roger.pau@xxxxxxxxxx, sstabellini@xxxxxxxxxx, dmukhin@xxxxxxxx
- Delivery-date: Wed, 25 Jun 2025 06:57:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/06/2025 23:56, dmkhn@xxxxxxxxx wrote:
> On Tue, Jun 24, 2025 at 09:49:39AM +0200, Orzel, Michal wrote:
>>
>>
>> On 24/06/2025 05:55, dmkhn@xxxxxxxxx wrote:
>>> From: Denis Mukhin <dmukhin@xxxxxxxx>
>>>
>>> Move vpl011 DT node parsing from common Arm code to PL011 emulator code.
>> It's not parsing, it's DT node generation.
>
> Oh, that's right, overlooked.
> Thanks, will update.
>
>>
>> We usually keep all the DT node generation functions in one place. I'm not
>> sure
>> if we want to move them to respective drivers (i.e. vpl011 to vpl011.c,
>> gicv3 to
>> gicv3.c, etc.). Not sure what other maintainers think.
>>
>>>
>>> While doing it pick the generic name vuart_add_fwnode() for DT parser
>>> function
>> What 'fw' stands for? Firmware? This function creates DT node for domU, so it
>> should better be sth like vuart_add_dt_node().
>
> 'fw' stands for 'firmware'.
>
> It should be some generic name because the function will be used on x86 to
> generate to generate the guest ACPI tables.
I see but maybe vuart_add_node() would be a better choice here.
~Michal
|
