[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] acpi/pm-op: make do_pm_op() decl available in pm-op.c
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Wed, 09 Jul 2025 13:41:25 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1752061285; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=ZhJNMBiic0c9LsCA/J6sklVgJBzmhChnnumDCFVj4Kc=; b=cHYd9LctLIXamErbtv3gOs005QEeo70GrvNaP6+kTcnKw9cLuTCwJdwTcWzmlnC0X9gC 0gJuYAA6FcDWfL/+9lZOr4N6ycP06tjzCWEMQ8dyjcGfdIYLJflf98ooCqEGdKn9+umlq Npzltx6KQYa3CDK5rknW4OD8yUBCoYHKJeFaj2+YJYEWq5ExSYY5nE24n7giBNl5WDXqA OoTcwjgroynrjeDhhCVbFyKW5eIKUQSyagHG4gjALwsH/CbKjK4B4uQtj/18tL3WBRFao cNcM4oyp5PkRA8lhjKITD2dFp+ukQqPh49Y47hTjaIKMRJCA0qEbqFNoWD9kOmwTJudci Uqtrw9cX5t4nIUN6yb08J/5IwCVzIhExURTzMlmz6mRkXxyEx3+siYS54TkZDjpi4H5Dc Jr5VOBeMVk4oJxCwvo09kp63zYPnGPONA5DMc0zDXeDJIekrA8NzG6wqmu+aUrnkcagn/ R+7tN68JXOtT3CzgHwoV0X4hwSUnnggRnWH0wSHtZIgbIda43O594zLvn10IcMb0j7tWY wkqkGWXog7rp2Bulmkr486Z4v3os2epVVEuYINjqIql2MqzoVjqRM3Hrg8l/0BadroG86 Zb+SAPZPcLMYougk57dwvdJIdi0tItstB+QxTJrobvodGEpSo0L6LfJmu5CTqjQ=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1752061285; b=rWrvLUV8JmtiT/gBYuUuiAx98dzSSQj0qmV0wm9dyZTmkFyMGDuFvsMamr2PLxDgzUdM LiMkCSZM+9w4kM34L2axpwbRV6e9GWPE+PXiu4Rm6C5SFcBO1sFDtEpfT2sE+ZZJAhXE7 F6H0kkvgIuwnkLCJ3HaOPF1vwjavLUtz35XDwu2IXB/6Pn4OspTNjBFN5UoxK41slqKuT 7U3AaJ4upOlHsgjJH4Qgd68pNAUPqsyW6Dn2Rp4W3NQ3F500ZJzcbez40HLyLYGUofA+H 5C0efY/NG69TgDf3Zc7Ty3EMPlAlsnH/YUl+nfs8iJOtlyVzuFzCu0bBZiKwCn1p4Lpzi g9lBAh5MgDYpVQmhGjZOT8V2EQsF79hS2QOrdXt/QkK1uQam48tTh6A32Ze8PImO4ZivW rNwoMDGvR0dtT5mLHbOBAIMehDe1Qm8iL70JyYUICMO/KK22heuhPUu2br3S/e9/cA0Ud PKmOWCtycPFKTw+E4JJ3ba/n9ctp3By9brF4Kxr7/69OEgvKXWiTtBlGQ+1LHimhCsQWR EmCUZoZBbFkS/7LNCQvp8rBOT4RAGzOK4OmgVJkKbVUP3QO/Ll9Iq8IWj8xXd0pkYd5JW 3Kr25Ytw2wD7Yy+AjZwBy9AA+DYBEv6MEUoLjvVGW239z4fV+iKkl+2a3oepSW8=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Penny Zheng <Penny.Zheng@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 09 Jul 2025 11:41:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-07-09 12:10, Jan Beulich wrote:
This addresses a Misra rule 8.4 ("A compatible declaration shall be
visible when an object or function with external linkage is defined")
violation.
Fixes: a16f2b3e0669 ("xen/pmstat: introduce CONFIG_PM_OP")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Perhaps a comment with the offending function would have been helpful
(do_pm_op).
--- a/xen/drivers/acpi/pm-op.c
+++ b/xen/drivers/acpi/pm-op.c
@@ -5,6 +5,7 @@
#include <xen/errno.h>
#include <xen/guest_access.h>
#include <xen/lib.h>
+#include <xen/pmstat.h>
#include <xen/sched.h>
#include <acpi/cpufreq/cpufreq.h>
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
